Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to be a release bump to v4.0.0 across the workspace crates, and it introduces feature flags in the tsalign binary to conditionally compile specific input alphabets and A* template-switch “total length” strategy implementations.
Changes:
- Bump crate versions from 3.0.0 → 4.0.0 across the Rust workspace (and update internal dependency version pins accordingly).
- Add
tsaligncrate features to gate supported alphabets and template-switch total-length strategies, and apply#[cfg(feature = ...)]gating in the CLI selector enums and strategy imports. - Update
Cargo.lockto reflect the new versions.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tsalign/src/align/template_switch_distance_type_selectors.rs |
Feature-gates total-length strategy selector variants and imports. |
tsalign/src/align.rs |
Feature-gates alphabet variants/imports and match arms used to select alphabet at runtime. |
tsalign/Cargo.toml |
Adds new feature flags and bumps internal dependency versions to 4.0.0. |
tsalign-tests/Cargo.toml |
Bumps package version to 4.0.0. |
seed_chain/Cargo.toml |
Bumps version to 4.0.0 and updates generic_a_star dependency version. |
python_bindings/Cargo.toml |
Bumps bindings crate version to 4.0.0 and updates internal dependency versions. |
lib_tsshow/Cargo.toml |
Bumps version to 4.0.0 and updates lib_tsalign dependency version. |
lib_tsalign/Cargo.toml |
Bumps version to 4.0.0 and updates internal dependency versions. |
lib_ts_chainalign/Cargo.toml |
Bumps version to 4.0.0 and updates internal dependency versions. |
generic_a_star/Cargo.toml |
Bumps version to 4.0.0. |
Cargo.lock |
Updates locked package versions to 4.0.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.