Repository navigation
Show how to install ffmpegd when it isn't connected - #60
Merged
Merged
Conversation
- Options: a line under the ffmpegd toggle says what ffmpegd is and links to its install guide. - When ffmpegd is enabled but unreachable, Options and the Queue show the address being tried and the setup steps: brew install, run it in the folder with your videos, and that the page connects on its own. - The steps wait 1.5s before appearing so a normal connect doesn't flash them.
- Options shows "Connecting to ffmpegd at ..." while the socket opens, then "Connected to ffmpegd at ..." once it does, or the setup steps if nothing answers. Before, connecting showed nothing in Options. - Replace "An older copy may need updating" with what it meant: ffmpegd 0.1.0 and earlier don't allow ffmpeg-commander.com and can't connect.
- The setup steps now say to make sure an existing install is up to date, rather than naming the versions that can't connect. - Move displayHost into lib/ffmpegd so FfmpegdSetup.tsx only exports components and constants (react/only-export-components).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Until now, the only mention of ffmpegd was the toggle label, "Send encode jobs to a local ffmpegd daemon (experimental)". When it couldn't connect, the Queue just said "● ffmpegd offline". Nothing explained what ffmpegd is or how to get it.
localhost:8080", using the saved address if one is setbrew install alfg/tap/ffmpegd, or follow the install guide for Windows, Go or Docker. The panel also asks people with an existing install to make sure it's up to date, since versions before 0.1.2 can't connect to ffmpeg-commander.comffmpegdin the folder with your videos, since paths are relative to itTesting
npm test);tsc -bandoxlintare clean. New tests cover the install link when ffmpegd is off, the connecting line and the grace period, the connected line replacing the steps, the saved address, the Queue, and the update note.🤖 Generated with Claude Code
https://claude.ai/code/session_01FJAB1xUz2Ks7btZ9WRyMgh