Skip to content

Respect a requeue after if it’s set in case the error wraps ErrQuiet #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
annismckenzie wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Respect a requeue after if it’s set in case the error wraps ErrQuiet #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions reconcilers/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,9 @@ func (r *ResourceReconciler[T]) Reconcile(ctx context.Context, req Request) (Res
result, err := r.AfterReconcile(ctx, req, AggregateResults(beforeResult, reconcileResult), err)
if errors.Is(err, ErrQuiet) {
// suppress error, while forcing a requeue
if result.RequeueAfter > 0 { // honor requeue after returned by reconciler
return result, nil
}
return Result{Requeue: true}, nil
}
return result, err
Expand Down
Loading