Add auto-update workflow for newt - #20
Conversation
|
This would make my PR (and the potential future ones) obsolete. |
alexmoras
left a comment
There was a problem hiding this comment.
Thanks for taking the time to submit this PR. There are a couple changes I think would be needed before we can merge. Mainly around the fact that the action doesn't have any awareness of the current version, and will create a new PR every time it runs, even if the version hasn't incremented.
| ' newt/CHANGELOG.md > tmp.md && mv tmp.md newt/CHANGELOG.md | ||
|
|
||
| - name: Create Pull Request | ||
| uses: peter-evans/create-pull-request@v6 |
There was a problem hiding this comment.
v8 is the latest, so probably best we implement based on that.
|
Further to the above code review, we need to consider whether automatic version incrementing is appropriate. I appreciate I do not update the versions all that often, but at least we know the add-on is stable. If we allow the action to automatically merge PRs, we risk implementing a version of Newt which isn't compatible with the add-on configuration, without some human changes. This could break people's access to HA. Also, this PR would not cause a new version of the add-on to be published. Another step would be needed to create a new GitHub Release, since this is what builds the new docker images. I'm open to suggestions, just wanted to raise a few points of discussion. 😄 |
|
Ah I messed it up :/
Yes you are totally right. I added a function that checks for the latest stable release (15 day delay after minor release)
I also change it to release and also trigger the build command |
This PR introduces a new GitHub Actions workflow to automatically update Newt to the newest version.
This reduces manual maintenance work for the repository.
Required Repository Changes:
For this workflow to run successfully, the repository settings must be updated. Please ensure the following: