fix: resolve release tag from remote when missing locally - #89
Merged
Conversation
The release step may run on a different agent than the tag step, so git tag -l finds nothing in a fresh shallow checkout. Add a 3-tier fallback chain: BUILDKITE_TAG, git fetch --tags + git tag -l, and git ls-remote --tags as final fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
releasestep resolves the version fromgit tag -l, which only finds tags present in the local checkout. Since thereleasestep may run on a different Buildkite agent than thetagstep, the freshly-created tag is missing — resulting inno tag foundand no GitHub release.Closes #88.
Fix
Added a 3-tier fallback chain:
BUILDKITE_TAG— populated for tag-push builds (fast path).git fetch --tags origin+git tag -l— pulls remote tags into the local clone first.git ls-remote --tags origin— queries the remote directly (works regardless of local state).If all three fail, the step exits silently (no tag = nothing to release).