fix(ci): local-first artifact resolution in release step; fix stateLabel for accepted - #85
Merged
Merged
Conversation
…bel for accepted Release step: use local files when present (single-agent), download only when missing. Eliminates the rename-file-exists conflict because we never download over an existing file. stateLabel: accepted state was falling through to default which returned 'acce'. Add explicit case for 'accepted' -> 'ACPT'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release step
The
rm -f + downloadapproach still fails: the download tries to rename a temp file onto the target path, but Buildkite's download may target a path where the file still exists (race with checkout refresh).Fix: Try local files first (left by
release_buildon the same agent). Only download from the artifact store when the file is missing. This avoids therename: file existsconflict entirely because we never write over an existing file.Step state label
acceptedstate fell through todefaultwhich returnedstate[:4]=acce. Added explicit case foraccepted→ACPT.