fix(ci): remove stale checkout files before artifact download - #84
Merged
Conversation
…ng release.sh The release step gets a fresh workspace — neither builddeck, builddeck.sha256, nor builddeck.tag survive from the previous step. Download all three from --step release_build before invoking release.sh so the GitHub release has real assets to upload. Same fix for pipeline.release.yml: download from --step build.
…ag step release_build was re-uploading builddeck.tag under its own step key, creating a duplicate. Switch release back to downloading from --step tag (where the original lives) with the [[ -s builddeck.tag ]] content guard. Binary and sha256 still come from --step release_build. Only the tag step publishes builddeck.tag — one artifact, no duplicates.
On single-agent setups, files from release_build persist in the checkout. The release step's artifact download tries to rename a temp file to builddeck, but the existing file blocks the rename. Remove stale files (builddeck, builddeck.sha256, builddeck.tag) before downloading fresh copies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The release step downloads
builddeckfrom--step release_build, but on single-agent setups the file already exists in the checkout from the previous step. Buildkite's artifact download renames a temp file to the target, which fails with*os.LinkError: rename ... builddeck: file exists.Fix: Remove stale files (
builddeck,builddeck.sha256,builddeck.tag) before downloading fresh copies. Clean and reliable across both single-agent and multi-agent setups.