fix(ci): download release binary and sha256 before creating GitHub release - #83
Merged
Merged
Conversation
…ng release.sh The release step gets a fresh workspace — neither builddeck, builddeck.sha256, nor builddeck.tag survive from the previous step. Download all three from --step release_build before invoking release.sh so the GitHub release has real assets to upload. Same fix for pipeline.release.yml: download from --step build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The release step gets a fresh workspace on every agent. Previously it only downloaded
builddeck.tag(from--step tag), but never downloadedbuilddeckorbuilddeck.sha256. The GitHub release was created with no assets.Also, relying on a
--step tagdownload meant the artifact might not have propagated yet when the release step ran.Fix:
release_buildre-uploadsbuilddeck.tagunder its own step key (only when a real tag was created — skips for "dev")releasedownloadsbuilddeck.tag,builddeck, andbuilddeck.sha256from--step release_build(immediately available — just ran)pipeline.release.ymlfor tag-push triggered builds