fix(ci): release step now downloads version from release_build artifacts - #82
Merged
Conversation
…release handoff The release step always got a fresh workspace, so the local builddeck.tag file from release_build was never available. The release step always skipped with 'No tag was created'. Fix: - release_build now re-uploads builddeck.tag (downloaded from tag step) under its own step key, so the artifact is immediately available to downstream steps. - release downloads from --step release_build (the step that just ran) instead of checking a local file. Includes the [[ -s builddeck.tag ]] content guard to prevent empty-version crashes. - Conditional upload: builddeck.tag is only uploaded from release_build if it exists and has content (i.e., a tag was created). 'dev' builds are not uploaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The release step checked
[[ -s builddeck.tag ]]locally, but Buildkite gives each step a fresh workspace — the file fromrelease_buildwas never available. Every main build that created a tag would log "No tag was created — skipping GitHub release."Fix:
release_buildnow re-uploadsbuilddeck.tagunder its own step key (only when a tag was actually created — skips for "dev" builds)releasedownloads from--step release_buildwith the[[ -s builddeck.tag ]]content guardtagstep)