fix: replace generic Error with typed AlexSDKError and fix fetchData bugs - #32
Open
vwinee21 wants to merge 1 commit into
Open
fix: replace generic Error with typed AlexSDKError and fix fetchData bugs#32vwinee21 wants to merge 1 commit into
vwinee21 wants to merge 1 commit into
Conversation
…bugs Add AlexSDKError class (RFC 9457-inspired) with machine-readable type URI, title, HTTP-equivalent status, and detail string. Replace all throw new Error(...) with typed AlexSDKError instances. Also fix two bugs in fetchData.ts: - getPrices() reported 'Failed to fetch token mappings' instead of 'Failed to fetch token prices' (wrong message, wrong function) - getPrices() used any for response shape — replaced with typed RawPriceEntry / RawPricesResponse - HTTP status codes from upstream now surfaced in error detail Consumers can now instanceof AlexSDKError and branch on error.type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace all
throw new Error(...)across the SDK with a typedAlexSDKErrorclass, and fix two bugs infetchData.ts.Changes
src/errors.ts(new)AlexSDKErrorclass withtype,title,status,detailfields — inspired by RFC 9457 Problem DetailsAlexErrorTypeconst enum:FetchFailed,RouteNotFound,TooManyPools,TokenMappingNotFoundsrc/utils/fetchData.ts— bug fixesgetPrices()was throwing'Failed to fetch token mappings'— correct message is'Failed to fetch token prices'getPrices()usedanyfor response shape — replaced with typedRawPriceEntry/RawPricesResponseAll helpers +
alexSDK.ts,postConditions.ts,utils.tsthrow new Error(...)replaced with typedAlexSDKErrorsrc/index.tsAlexSDKErrorandAlexErrorTypefor consumersWhy
Generic
throw new Error()forces consumers to parse message strings to distinguish error types. WithAlexSDKError: