ci(release): build assets from release workflow#8
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the release-please GitHub Actions workflow to build and publish Store-ready MSIX bundle assets as part of the release-please run, so releases automatically include the generated artifacts without needing a separate packaging workflow.
Changes:
- Prevent release-please workflow runs from being cancelled by later pushes by disabling
cancel-in-progress. - Export
release-pleasestep outputs (release_created/tag_name/version) for downstream jobs. - Add a Windows job that checks out the created release tag, builds the Store MSIX bundle, uploads it as a workflow artifact, and attaches it to the GitHub Release.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+61
to
+67
| $platformXml = "C:\Program Files (x86)\Windows Kits\10\Platforms\UAP\10.0.22621.0\Platform.xml" | ||
| if (-not (Test-Path $platformXml)) { | ||
| Write-Host "Installed UAP SDK platforms:" | ||
| Get-ChildItem "C:\Program Files (x86)\Windows Kits\10\Platforms\UAP" -ErrorAction SilentlyContinue | | ||
| Select-Object -ExpandProperty FullName | ||
| throw "Required Windows SDK UAP platform file not found: $platformXml" | ||
| } |
Comment on lines
+99
to
+104
| uses: softprops/action-gh-release@v2 | ||
| with: | ||
| tag_name: ${{ needs.release-please.outputs.tag_name }} | ||
| files: | | ||
| artifacts/release/*.msixbundle | ||
| artifacts/release/bundle_mapping.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
yq e '.jobs | keys' .github/workflows/release-please.ymlyq e '.jobs.build-store-bundle.if' .github/workflows/release-please.ymlgit diff --check