Refactor vnstat - #22
Open
AllanKlaus wants to merge 1 commit into
Open
Conversation
Owner
|
I'm getting the following error: PHP Fatal error: Cannot pass parameter 4 by reference in /var/www/vnstat/vnstat.php on line 119 |
- Motivation The function getVnstatData is very complex. I created a function generateGraph that perform the same of 4 foreachs on that function getVnstatData.
AllanKlaus
force-pushed
the
refactor-vnstat
branch
from
October 5, 2018 11:40
9ad827b to
3006184
Compare
Author
|
I updated it. Maybe could be another way to do it and i'm not seeing it now. I added a var |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The function
getVnstatDatais very complex. I created a functiongenerateGraphthat perform the same of 4 foreachs on that functiongetVnstatData.Issue: #14