Skip to content

UTC-aware datetime/cryptography.x509 modernization; python >= 3.12, cryptography.x509 >= 42.0.0 #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jimmbelll wants to merge 1 commit into
base: master
Choose a base branch
from
Open

UTC-aware datetime/cryptography.x509 modernization; python >= 3.12, cryptography.x509 >= 42.0.0 #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ask-sdk-webservice-support/ask_sdk_webservice_support/verifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import warnings

from dateutil import tz
from datetime import datetime
from datetime import datetime, UTC as dt_UTC
from abc import ABCMeta, abstractmethod
from ask_sdk_runtime.exceptions import AskSdkException
from six.moves.urllib.parse import urlparse
Expand Down Expand Up @@ -372,9 +372,9 @@ def _validate_end_certificate(self, x509_cert):
:raises: :py:class:`VerificationException` if certificate is
not valid
"""
now = datetime.utcnow()
if not (x509_cert.not_valid_before <= now <=
x509_cert.not_valid_after):
now = datetime.now(dt_UTC)
if not (x509_cert.not_valid_before_utc <= now <=
x509_cert.not_valid_after_utc):
raise VerificationException("Signing Certificate expired")

ext = x509_cert.extensions.get_extension_for_oid(
Expand Down