Repository navigation
Conversation
ps-occrp
requested changes
Oct 22, 2024
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| {{- if .Values.api.serviceAnnotations }} |
There was a problem hiding this comment.
If you specify default value it will always be there, you don't need to check that it exists.
| metadata: | ||
| {{- if .Values.api.serviceAnnotations }} | ||
| annotations: | ||
| {{- range $key, $value := .Values.api.serviceAnnotations }} |
There was a problem hiding this comment.
Can you implement it like helm does it here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running Aleph in the google cloud with container native loadbalancing, the healthcheck of the default
BackendConfiggoogle cloud generates won't work (because of the non-standard nameapiof the service port if i remember correctly.).This can be solved in multiple ways:
httpwould make the defaults work, but i haven't tested this.annotationson the service. Which seems like a good idea anyway.