Repository navigation
fix(devnet.sh): run the build command without eval - #4577
Merged
Merged
Conversation
cbeck88
marked this pull request as ready for review
October 26, 2026 11:48
brunoffranca
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
scripts/devnet.shbuilds itscargo installcommand as a string and runs it witheval. The shell parses the string again. A checkout path with spaces then breaks the build. The shell also interprets the text from the feature prompt as shell syntax.This PR builds the command as an array and runs it without
eval. The repo path and the feature list each stay one argument.Copilot reported this on #4525. It is the high-severity item in #4533.
Commits:
fix(devnet.sh): run the build command as an argv array instead ofeval.Test Plan
bash -n scripts/devnet.shpasses.test_network;touch PWNED. Each value stayed one argument. The shell did not runtouch.Documentation
None.
Backwards compatibility
None. This change affects only a local developer script.
🤖 Generated with Claude Code