Fix - Queue bots in Tourney#90
Merged
Merged
Conversation
When switching to Tourney gametype, bots already in-game were sitting in the non-queued spectator list, and never joining the game when a slot opened up. Bots will now be queued up instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Bots sit in the spectator list when gametype is changed to Tournament. They don't join the game unless you kick the current bot and allow a fresh one to connect.
Cause: When we introduced a second class of spectator, 'queued' to join the game, bots were still being assigned into the regular non-queued group of spectators. So they never join the game even when a slot opens up. there was no logic to ever promote them into the queue.
Solution: Assign them into the queued-to-play group when they join the game after map/gametype change.