test: avoid secret-shaped literals in redaction tests#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
This PR keeps the existing redaction behavior and tests, but changes the test fixtures so they no longer contain full static strings that look like real API keys or access tokens.
Why
The redaction helper intentionally tests common credential prefixes. The previous tests used complete fake token-like literals directly in the source file.
Those values were not real credentials, but secret scanners can still flag them because they match credential-shaped patterns. This PR avoids that noise while preserving the same test coverage.
How
Instead of hardcoding complete token-shaped literals, the tests now build those strings at runtime from smaller parts.
The assertions still verify the same redacted output, so the helper behavior is unchanged.
Scope
Follow-up
A later PR can apply the redaction helper at real output boundaries such as provider errors, tool outputs, Telegram failure messages, and UI-facing error formatting.