Repository navigation
feat(mcp): add MCP server management - #25
Closed
alanwang233233 wants to merge 4 commits into
Closed
alanwang233233 wants to merge 4 commits into
alanwang233233 wants to merge 4 commits into
Conversation
Co-authored-by: alanwang233233 <107164653+alanwang233233@users.noreply.github.com>
|
No reviewable changes. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
CI 检查结果汇总
信息展示
📋 pytest 详细============================= test session starts ==============================
platform linux -- Python 3.14.8, pytest-9.1.1, pluggy-1.6.0
rootdir: /home/runner/work/MitoCode/MitoCode
configfile: pyproject.toml
plugins: asyncio-1.4.0, platformdirs-4.13.0, cov-7.1.0, anyio-4.15.1
asyncio: mode=Mode.STRICT, debug=False, asyncio_default_fixture_loop_scope=None, asyncio_default_test_loop_scope=function
collected 144 items
test/test_agent_runtime.py ............................ [ 19%]
test/test_agent_session.py ............................................. [ 50%]
............ [ 59%]
test/test_main.py . [ 59%]
test/test_orchestrator_and_bridge.py ............ [ 68%]
test/test_tool_manager.py ...... [ 72%]
test/test_workspace.py ...................................... [ 98%]
test/test_workspace_async.py .. [100%]
------ generated xml file: /home/runner/work/MitoCode/MitoCode/report.xml ------
================================ tests coverage ================================
_______________ coverage: platform linux, python 3.14.8-final-0 ________________
Name Stmts Miss Cover
--------------------------------------------------------------------------------
src/mitocode/__init__.py 4 0 100%
src/mitocode/backend/__init__.py 3 0 100%
src/mitocode/backend/agent/__init__.py 8 0 100%
src/mitocode/backend/agent/agent_node.py 10 0 100%
src/mitocode/backend/agent/agent_orchestrator.py 115 35 70%
src/mitocode/backend/agent/agent_runtime.py 91 0 100%
src/mitocode/backend/agent/agent_session.py 133 1 99%
src/mitocode/backend/agent/agent_state.py 8 0 100%
src/mitocode/backend/agent/session_factory.py 6 0 100%
src/mitocode/backend/bridge/__init__.py 2 0 100%
src/mitocode/backend/bridge/event_adapter.py 25 0 100%
src/mitocode/backend/chat_provider/__init__.py 4 0 100%
src/mitocode/backend/chat_provider/chat_provider_openai.py 50 34 32%
src/mitocode/backend/chat_provider/sample_chat_provider.py 39 18 54%
src/mitocode/backend/exception/__init__.py 2 0 100%
src/mitocode/backend/exception/mitocode_exception.py 19 0 100%
src/mitocode/backend/tool/__init__.py 2 0 100%
src/mitocode/backend/tool/tool_manager.py 105 28 73%
src/mitocode/backend/workspace/__init__.py 3 0 100%
src/mitocode/backend/workspace/migration.py 77 39 49%
src/mitocode/backend/workspace/snapshot.py 0 0 100%
src/mitocode/backend/workspace/workspace.py 180 11 94%
--------------------------------------------------------------------------------
TOTAL 886 166 81%
Coverage XML written to file coverage.xml
Required test coverage of 80% reached. Total coverage: 81.26%
============================= 144 passed in 1.58s ==============================
🔒 gitleaks 详细[]📝 pyright 输出自动提交状态: 已自动提交 ✅ 由 CI 自动生成 |
alanwang233233
requested review from
duanygithub
and
a lite review from Copilot
October 14, 2026 02:45
There was a problem hiding this comment.
🟡 Changes recommended
Remove the hardcoded credential and implement or correctly scope the claimed MCP functionality.
2 open findings
What changed in this PR
The PR claims to add MCP server management, but the changes only reformat existing provider setup and remove whitespace.
Changes:
- Reformatted OpenAI provider initialization.
- Removed an extra blank line.
- Retained a hardcoded credential-like API key.
| File | Summary |
|---|---|
src/mitocode/backend/chat_provider/scenario_provider.py |
Removed an unnecessary blank line. |
src/mitocode/__main__.py |
Reformatted provider setup; retains an exposed credential and lacks MCP implementation. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| default_tools=None, | ||
| stream=True, | ||
| settings={ | ||
| "api_key": "sk-别看了这次我不会再把key提交到仓库了！", |
Comment on lines
+72
to
+74
| provider = asyncio.run( | ||
| ChatProviderOpenAI.factory( | ||
| default_model="nvidia/nemotron-3.5-lightning:free", |
alanwang233233
marked this pull request as draft
October 16, 2026 12:32
Contributor
CI 检查结果汇总
信息展示
📋 pytest 详细============================= test session starts ==============================
platform linux -- Python 3.14.8, pytest-9.1.1, pluggy-1.7.0
rootdir: /home/runner/work/MitoCode/MitoCode
configfile: pyproject.toml
plugins: asyncio-1.4.0, platformdirs-4.13.3, cov-7.1.0, anyio-4.15.1
asyncio: mode=Mode.STRICT, debug=False, asyncio_default_fixture_loop_scope=None, asyncio_default_test_loop_scope=function
collected 144 items
test/test_agent_runtime.py ............................ [ 19%]
test/test_agent_session.py ............................................. [ 50%]
............ [ 59%]
test/test_main.py . [ 59%]
test/test_orchestrator_and_bridge.py ............ [ 68%]
test/test_tool_manager.py ...... [ 72%]
test/test_workspace.py ...................................... [ 98%]
test/test_workspace_async.py .. [100%]
------ generated xml file: /home/runner/work/MitoCode/MitoCode/report.xml ------
================================ tests coverage ================================
_______________ coverage: platform linux, python 3.14.8-final-0 ________________
Name Stmts Miss Cover
--------------------------------------------------------------------------------
src/mitocode/__init__.py 4 0 100%
src/mitocode/backend/__init__.py 3 0 100%
src/mitocode/backend/agent/__init__.py 8 0 100%
src/mitocode/backend/agent/agent_node.py 10 0 100%
src/mitocode/backend/agent/agent_orchestrator.py 115 35 70%
src/mitocode/backend/agent/agent_runtime.py 91 0 100%
src/mitocode/backend/agent/agent_session.py 133 1 99%
src/mitocode/backend/agent/agent_state.py 8 0 100%
src/mitocode/backend/agent/session_factory.py 6 0 100%
src/mitocode/backend/bridge/__init__.py 2 0 100%
src/mitocode/backend/bridge/event_adapter.py 25 0 100%
src/mitocode/backend/chat_provider/__init__.py 4 0 100%
src/mitocode/backend/chat_provider/chat_provider_openai.py 50 34 32%
src/mitocode/backend/chat_provider/sample_chat_provider.py 39 18 54%
src/mitocode/backend/exception/__init__.py 2 0 100%
src/mitocode/backend/exception/mitocode_exception.py 19 0 100%
src/mitocode/backend/tool/__init__.py 2 0 100%
src/mitocode/backend/tool/tool_manager.py 105 28 73%
src/mitocode/backend/workspace/__init__.py 3 0 100%
src/mitocode/backend/workspace/migration.py 77 39 49%
src/mitocode/backend/workspace/snapshot.py 0 0 100%
src/mitocode/backend/workspace/workspace.py 180 11 94%
--------------------------------------------------------------------------------
TOTAL 886 166 81%
Coverage XML written to file coverage.xml
Required test coverage of 80% reached. Total coverage: 81.26%
============================= 144 passed in 1.29s ==============================
🔒 gitleaks 详细[]📝 pyright 输出自动提交状态: 无变更可提交 由 CI 自动生成 |
alanwang233233
force-pushed
the
feat/mcp
branch
from
October 16, 2026 13:51
708817a to
be1d909
Compare
Contributor
CI 检查结果汇总
信息展示
📋 pytest 详细============================= test session starts ==============================
platform linux -- Python 3.14.8, pytest-9.1.1, pluggy-1.7.0
rootdir: /home/runner/work/MitoCode/MitoCode
configfile: pyproject.toml
plugins: asyncio-1.4.0, platformdirs-4.13.3, cov-7.1.0, anyio-4.15.1
asyncio: mode=Mode.STRICT, debug=False, asyncio_default_fixture_loop_scope=None, asyncio_default_test_loop_scope=function
collected 144 items
test/test_agent_runtime.py ............................ [ 19%]
test/test_agent_session.py ............................................. [ 50%]
............ [ 59%]
test/test_main.py . [ 59%]
test/test_orchestrator_and_bridge.py ............ [ 68%]
test/test_tool_manager.py ...... [ 72%]
test/test_workspace.py ...................................... [ 98%]
test/test_workspace_async.py .. [100%]
------ generated xml file: /home/runner/work/MitoCode/MitoCode/report.xml ------
================================ tests coverage ================================
_______________ coverage: platform linux, python 3.14.8-final-0 ________________
Name Stmts Miss Cover
--------------------------------------------------------------------------------
src/mitocode/__init__.py 4 0 100%
src/mitocode/backend/__init__.py 3 0 100%
src/mitocode/backend/agent/__init__.py 8 0 100%
src/mitocode/backend/agent/agent_node.py 10 0 100%
src/mitocode/backend/agent/agent_orchestrator.py 115 35 70%
src/mitocode/backend/agent/agent_runtime.py 91 0 100%
src/mitocode/backend/agent/agent_session.py 133 1 99%
src/mitocode/backend/agent/agent_state.py 8 0 100%
src/mitocode/backend/agent/session_factory.py 6 0 100%
src/mitocode/backend/bridge/__init__.py 2 0 100%
src/mitocode/backend/bridge/event_adapter.py 25 0 100%
src/mitocode/backend/chat_provider/__init__.py 4 0 100%
src/mitocode/backend/chat_provider/chat_provider_openai.py 50 34 32%
src/mitocode/backend/chat_provider/sample_chat_provider.py 39 18 54%
src/mitocode/backend/exception/__init__.py 2 0 100%
src/mitocode/backend/exception/mitocode_exception.py 19 0 100%
src/mitocode/backend/tool/__init__.py 2 0 100%
src/mitocode/backend/tool/tool_manager.py 105 28 73%
src/mitocode/backend/workspace/__init__.py 3 0 100%
src/mitocode/backend/workspace/migration.py 77 39 49%
src/mitocode/backend/workspace/snapshot.py 0 0 100%
src/mitocode/backend/workspace/workspace.py 180 11 94%
--------------------------------------------------------------------------------
TOTAL 886 166 81%
Coverage XML written to file coverage.xml
Required test coverage of 80% reached. Total coverage: 81.26%
============================= 144 passed in 1.08s ==============================
🔒 gitleaks 详细[]📝 pyright 输出自动提交状态: 无变更可提交 由 CI 自动生成 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(mcp): add MCP server management