Repository navigation
test(api): fix flaky performance tests - #446
Merged
Merged
Conversation
…monotonically (flaky memory-target failures)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: performance tests measured process-wide GC heap deltas while other xUnit collections ran in parallel, and GC.GetTotalMemory deltas can shrink when a GC fires mid-operation, so the memory-reduction target failed only in full runs. Fix: CollectionDefinition(DisableParallelization=true) for all 5 performance collections + GC.GetTotalAllocatedBytes(precise) measurement. PerformanceIsolationTests enforces it (failed before). Other historical failures (report path, OpenAI timeout bound, flag-off, concurrent create) already fixed on main; concurrent-create 15/15. Full dotnet test 3 consecutive runs: 1337 passed, 0 failed.