Skip to content

Fix newsletter popup deploy path derivation - #9

Merged
alanw707 merged 1 commit into
mainfrom
fix/newsletter-popup-deploy-path
Oct 12, 2026
Merged

alanw707 merged 1 commit into
mainfrom
fix/newsletter-popup-deploy-path

Conversation

@alanw707

Copy link
Copy Markdown
Owner

Summary

  • derive the plugin path from relative, site-root-relative, or absolute theme paths
  • fail closed on wrong or unsafe path components
  • add regression coverage for the production path shape that blocked the first deployment

Evidence

  • subagent deployment-path review: PASS
  • bash tests/scripts/deploy-file.test.sh passes
  • YAML parse and git diff --check pass

The previous production run failed before touching the plugin; theme deployment completed.

@alanw707
alanw707 merged commit a81ad66 into main Oct 12, 2026
7 checks passed
@alanw707
alanw707 deleted the fix/newsletter-popup-deploy-path branch October 12, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant