ci: use shared nexus-workflows upload workflow#2
Conversation
…workflow Splits the Nexus upload out of the monolithic build job into its own job that calls the shared reusable workflow, replacing the inline dotnet-installed agc93/NexusUploader (UNEX_COOKIES) with the maintained BUTR.NexusUploader fork via UNEX_NEXUSMODS_SESSION_COOKIE, matching sibling repos. Also adds check_existing: true for idempotent re-runs (safe against duplicate changelog entries as of nexus-workflows v1.5.2, alandtse/Nexus-Workflows#8). UNEX_NEXUSMODS_SESSION_COOKIE and UNEX_APIKEY were already distributed to this repo by the Nexus-Secrets controller; UNEX_COOKIES is no longer used and can be removed once this lands. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G5JEn6sUpkBx2o68oLBmqk
|
Warning Review limit reached
Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Most repos calling this reusable workflow already track @main rather than a pinned SHA; switching this one back matches that convention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G5JEn6sUpkBx2o68oLBmqk
…gin alias cycjimmy/semantic-release-action@v3 with the @achingbrain/semantic-release-github tarball-aliased @semantic-release/github install was failing npm install (no usable stderr surfaced by the action, just a generic "Command failed" error). .releaserc already references the plain @semantic-release/github plugin, and fallout_vr_address_library already runs cleanly on @v4 with the plain package, so this drops the years-old alias workaround and matches that known-working config. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G5JEn6sUpkBx2o68oLBmqk
actions/checkout v3->v7, lukka/run-vcpkg v10->v11, cycjimmy/semantic-release-action v4->v6, svenstaro/upload-release-action 2.3.0->2.11.5. lukka/run-cmake and lukka/get-cmake were already tracking their latest majors. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G5JEn6sUpkBx2o68oLBmqk
pre-commit.ci was erroring on this PR ("error during ci config") because the
repo had no .pre-commit-config.yaml at all. Adds one, which surfaced:
- trailing-whitespace/EOF fixes in a handful of files (whitespace only,
including src/MergeMapper.cpp)
- unex-check.yml still used the old agc93/NexusUploader tool and UNEX_COOKIES
secret, both already replaced in the real upload path by this PR — migrated
it to BUTR.NexusUploader + UNEX_NEXUSMODS_SESSION_COOKIE/UNEX_APIKEY so the
daily credential check actually validates what's used
- check-json excludes .vscode/ (VS Code config files are JSONC, not JSON)
- actionlint's report on build.yml's `${{ runner.workspace }}` is suppressed
via -ignore rather than "fixed": it's not a valid expression context, but
the CI run already confirmed the resulting path resolves correctly in
practice, and the technically-correct replacement (github.workspace) is a
different directory (one level deeper), which would be a real behavior
change disguised as a lint fix
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G5JEn6sUpkBx2o68oLBmqk
alandtse
changed the title
alandtse
changed the title
1 participant
Summary
job(build) into its ownnexus-uploadjob that calls the sharedalandtse/nexus-workflowsreusable workflow (upload-nexus.yml@v1.5.2), the same one used by sibling repos (e.g.skyrim_vr_address_library,fallout_vr_address_library).dotnet tool install -g NexusUploader(the older, unmaintained agc93/nexus-uploader, usingUNEX_COOKIES) with the maintained BUTR.NexusUploader fork viaUNEX_NEXUSMODS_SESSION_COOKIE+UNEX_APIKEY— both already present in this repo's secrets (distributed by the Nexus-Secrets controller), no new secret setup needed.check_existing: trueso re-runs against an already-uploaded version are idempotent instead of always re-uploading. This is safe against the duplicate-changelog bug fixed in nexus-workflows v1.5.2 (fix: gate Nexus changelog repost on version-exists to prevent duplicate entries Nexus-Workflows#8).jobgains anoutputs:block (new_release_published,new_release_version,new_release_git_tag,new_release_notes) sonexus-uploadcan consume them — no change to the build/release steps themselves.UNEX_COOKIESsecret can be removed after this merges.Test plan
workflow_dispatchafter a merge to main) publishes normally and thenexus-uploadjob completes successfully🤖 Generated with Claude Code
https://claude.ai/code/session_01G5JEn6sUpkBx2o68oLBmqk