fix: bump CommonLibF4 to fix C++23 aligned_storage deprecation#37
Conversation
The 1.38.0 release build failed: the updated MSVC STL on GitHub's runners emits C4996/STL4034 for the deprecated std::aligned_storage_t in CommonLibF4's RE/msvc/functional.h, which Buffout4's global /WX promotes to an error. This blocked the build and, in turn, the Nexus upload. Bump the submodule to include alandtse/CommonLibF4#43, which replaces the deprecated type with the recommended alignas(T) std::byte buffer (identical layout). No Buffout4 source changes are required; the bump also brings in the already-present ESL FormID handling for crash logs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 31 minutes and 35 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The path filter watched `extern/**`, but the CommonLibF4 submodule lives at `external/CommonLibF4` (see .gitmodules `path =`). As a result, submodule bumps never triggered the build test — including the bump in this PR. Point the filter at `external/**` so dependency updates are actually built. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
## [1.38.1](v1.38.0...v1.38.1) (2026-06-02) ### Bug Fixes * bump CommonLibF4 to fix C++23 aligned_storage deprecation ([#37](#37)) ([4d1ca4d](4d1ca4d))
|
🎉 This PR is included in version 1.38.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 participant
Problem
The
1.38.0Semantic Release run failed at the Build Release step, so the Upload to Nexus Mods step never ran (it's gated on a successful build).Root cause: GitHub's runner image updated MSVC's STL, which now emits C4996 / STL4034 for the deprecated
std::aligned_storage_tused in CommonLibF4'sRE/msvc/functional.h. Buffout4 sets/WXglobally inCMakePresets.json, promoting it to a hard error:This is not related to the Nexus workflow migration (#36) — that step is fine; the build simply never got there.
Fix
Bump the
CommonLibF4submodule to include alandtse/CommonLibF4#43, which replacesstd::aligned_storage_t<3 * sizeof(void*), alignof(long double)>with the MSVC-recommendedalignas(long double) std::byte _storage[3 * sizeof(void*)]. Layout is byte-identical (24 bytes, align 8,_fnat0x18), so the ABI mirror ofstd::_Func_classis unchanged. No Buffout4 source changes required.Verification
windowsconfigs green (release/debug × all/flat/vr)./std:c++latest /W4 /WX): old form reproduced the exactC2220/C4996error; new form compiles clean and passesstatic_asserts confirming identical size/offset/alignment.Bonus: ESL support
The bumped CommonLibF4 carries the ESL-aware FormID handling (
smallFileCompileIndex/0xFElight-plugin decoding). Buffout4 already calls these APIs (e.g. the[FE:xxx]plugin lines in crash logs), so this release ships correct ESL attribution with no further changes.🤖 Generated with Claude Code