Skip to content

CRW-9373-wave5-finalization#18

Open
akurinnoy wants to merge 4 commits into
mainfrom
supervisor/b7287dcf-a05b-4d16-afbf-09a246864978
Open

CRW-9373-wave5-finalization#18
akurinnoy wants to merge 4 commits into
mainfrom
supervisor/b7287dcf-a05b-4d16-afbf-09a246864978

Conversation

@akurinnoy

Copy link
Copy Markdown
Owner

Summary

Automated implementation via supervisor execution pipeline.

Run ID: b7287dcf-a05b-4d16-afbf-09a246864978
Plan ID: CRW-9373-wave5-finalization
Waves completed: 2/2

Tasks

  • T1: Fix misleading comment in AddPersistentHomeVolume and verify tests pass
  • T2: Add YAML fixture for backward-compat: non-ephemeral workspace without custom DWOC init containers still gets default init
  • T3: Update PR CRW-9373-run-77683332 #17 description with proper feature documentation

Integration Waves

  • Wave 1: merged T1, T2
  • Wave 2: merged T3

akurinnoy and others added 4 commits July 2, 2026 14:24
The comment claimed the default init container was skipped when custom
init containers were present, but the code only checks DisableInitContainer.
Update the comment to accurately reflect the actual condition.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…pty DWOC initContainers

Add YAML test fixture covering the backward-compatibility path where
DWOC workspace.initContainers is set to an explicit empty list ([]). In
this case, a non-ephemeral workspace with persistUserHome.enabled=true
still gets the default init-persistent-home init container injected, as
the empty initContainers list does not disable the default behavior.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant