dwoc-custom-init-containers-v1#16
Open
akurinnoy wants to merge 5 commits into
Open
Conversation
When a caller supplies an explicit Command to the init-persistent-home container, validate that it equals exactly [/bin/sh, -c]. Any other value returns a descriptive error so the workspace controller can fail the workspace cleanly. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Adds TestEnsureHomeInitContainerFields covering empty command default, valid command passthrough, invalid command errors, and VolumeMount assertions. Includes a comment explaining why no YAML fixture is added. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
… tests - Remove unused expectCustomInitSkipped bool field from TestCustomInitPersistentHome - Add TestNeedsPersistentHomeDirectoryEphemeral covering the ephemeral storage branch of NeedsPersistentHomeDirectory introduced in T1: ephemeral workspaces return false unless init-persistent-home is explicitly in the DWOC - TestEnsureHomeInitContainerFields already present; no YAML fixtures added because EnsureHomeInitContainerFields is not on the AddPersistentHomeVolume path Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated implementation via supervisor execution pipeline.
Run ID: cfc7c778-d1fb-4849-8782-0da861703254
Plan ID: dwoc-custom-init-containers-v1
Waves completed: 3/3
Tasks
Integration Waves