dwoc-custom-init-containers#12
Open
akurinnoy wants to merge 10 commits into
Open
Conversation
Verified baseline build and tests pass on HEAD cdc8050. Mapped exact line numbers for EnsureHomeInitContainerFields (persistentHome.go:252-262), the controller call site (devworkspace_controller.go:435-441), and documented all existing command validation gaps for T2/T3. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Reject a custom init-persistent-home container whose Command is non-empty and not exactly ["/bin/sh", "-c"]. Uses reflect.DeepEqual for comparison. Returns: "Invalid init-persistent-home container: command must be exactly [/bin/sh, -c]" Update controller call site to surface the error message directly via r.failWorkspace(err.Error()) without wrapping prefix. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…WOC init containers - Add table-driven tests for EnsureHomeInitContainerFields covering: empty command (gets default /bin/sh -c), valid command accepted unchanged, /bin/bash -c rejected with exact error message, /bin/sh without -c rejected - Add VolumeMounts assertion tests verifying persistent-home mount on /home/user/ - Add full-flow tests verifying two non-init-persistent-home DWOC containers appear after init-persistent-home and order is preserved - Add MergeInitContainers test verifying new-named patch container is appended Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…e path Add three new YAML fixture files for TestPersistentHomeVolume: - no-dwoc-init-containers.yaml: verifies that when no DWOC initContainers are configured, the default stow-based init-persistent-home devfile component is added (backward compatibility path). - dwoc-override-init-persistent-home.yaml: verifies that when DWOC specifies init-persistent-home with only args (no command field), the devfile TemplateSpec still receives the default stow-based init component via AddPersistentHomeVolume. No volumeMounts or corev1.Container fields are asserted in the DWOC initContainers input. - ephemeral-with-init-persistent-home-in-dwoc.yaml: verifies that NeedsPersistentHomeDirectory returns true for ephemeral storage when init-persistent-home is configured in DWOC, causing AddPersistentHomeVolume to be called and add the persistent-home volume. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…/4 | Tasks: T3, T4]
…/4 | Tasks: T3, T4]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated implementation via supervisor execution pipeline.
Run ID: 54e4cf33-4920-4e10-b9e8-2320486d3435
Plan ID: dwoc-custom-init-containers
Waves completed: 4/4
Tasks
Integration Waves