devworkspace-custom-init-containers-gaps#10
Open
akurinnoy wants to merge 6 commits into
Open
Conversation
If a custom init-persistent-home container has a command other than [/bin/sh, -c], return an error instead of silently accepting it. Uses reflect.DeepEqual for exact slice comparison. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Adds a new 'DWOC init containers' Context block to devworkspace_controller_test.go with three It() cases: basic custom init injection, init-persistent-home override when persistent home is enabled, and skipping init-persistent-home when disabled. Adds a minimal supporting fixture YAML for the new tests. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Add table-driven tests for EnsureHomeInitContainerFields verifying: - nil command gets default [/bin/sh, -c] - exact [/bin/sh, -c] command is kept as-is - different commands return error with message 'command must be exactly [/bin/sh, -c]' - partial match commands also return error - VolumeMounts are set to home volume mount on success - existing env vars and other container fields are preserved Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated implementation via supervisor execution pipeline.
Run ID: devworkspace-custom-init-containers-gaps-no-ts
Plan ID: devworkspace-custom-init-containers-gaps
Waves completed: 2/2
Tasks
Integration Waves