chore: go version bump for ci and releases - #6869
Open
fuskovic wants to merge 2 commits into
Open
Conversation
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
kargo-governance-bot
Bot
added
needs/area
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kargo-governance-bot
Bot
added
the
needs/priority
fuskovic
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6869 +/- ##
==========================================
+ Coverage 31.04% 35.54% +4.49%
==========================================
Files 835 835
Lines 81453 68603 -12850
==========================================
- Hits 25290 24386 -904
+ Misses 54692 44217 -10475
+ Partials 1471 0 -1471 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
krancour
approved these changes
Aug 24, 2026
krancour
reviewed
Aug 25, 2026
Comment on lines
+146
to
+169
| # goconst findings surfaced by the golangci-lint v2.13.1 upgrade | ||
| # (bumped for Go 1.27 support). Left as follow-up cleanup rather than | ||
| # bundling it with an unrelated Go version bump. | ||
| - linters: | ||
| - goconst | ||
| path: pkg/cli/cmd/get/.*\.go | ||
| - linters: | ||
| - goconst | ||
| path: pkg/controller/management/projects/projects\.go | ||
| - linters: | ||
| - goconst | ||
| path: pkg/controller/warehouses/warehouses\.go | ||
| - linters: | ||
| - goconst | ||
| path: pkg/promotion/runner/builtin/(git_pr_opener|git_pr_waiter|helm_chart_updater|json_updater|kustomize_image_setter|toml_updater|yaml_merger|yaml_updater)\.go | ||
| - linters: | ||
| - goconst | ||
| path: pkg/server/(get_cluster_config|get_project_config|get_promotion|get_stage|get_warehouse)\.go | ||
| - linters: | ||
| - goconst | ||
| path: pkg/server/rbac/(generic_escalation|roles)\.go | ||
| - linters: | ||
| - goconst | ||
| path: pkg/webhook/external/(azure|github|refresh)\.go |
Member
There was a problem hiding this comment.
There's just no way we're going to enjoy keeping this up to date.
Member
There was a problem hiding this comment.
Is there some other way to relax goconst a bit without naming files?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up for #6860 per #6860 (comment)