feat(ui): surface subscription names in the UI - #6868
Merged
Conversation
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
…t assembly Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Threads subscriptionName through flattenFreightOrigin so the freight details table and the promotion drawer's comparison table can show which subscription produced an artifact. Also keys artifact pairing and freight timeline chips on the subscription name, so two named subscriptions to the same repository no longer collapse into one row or share a React key. Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kargo-governance-bot
Bot
added
area/ui
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6868 +/- ##
==========================================
+ Coverage 30.90% 31.04% +0.14%
==========================================
Files 829 835 +6
Lines 80864 81453 +589
==========================================
+ Hits 24990 25290 +300
- Misses 54418 54692 +274
- Partials 1456 1471 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rpelczar
reviewed
Aug 24, 2026
rpelczar
left a comment
rpelczar
left a comment
Contributor
There was a problem hiding this comment.
I think using tags for names isn't the best idea. Especially when one is clickable and the next one is not.
I think we should replace the current name taken from the URL with the new name field. It should fall back to the previous value.
In the table, we can just add a new column.
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
A blue Tag reads as a link everywhere else in the UI, but a subscription name is not navigable. Render it as Typography.Text instead, and give it its own place in each view rather than crowding an existing label: - pipeline subscription node: the name becomes the header title, and the link below carries the whole repo URL instead of just its base - warehouse Subscriptions tab: out of the Descriptions title, into a Name row - freight table and promotion comparison table: its own Name column Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Contributor
Author
|
Done @rpelczar |
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6729
Shows a subscription's name wherever the UI identifies a subscription or the artifacts it produced.