fix(bloom): carry #n through union and bound create n to uint32 - #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes two
#n-handling gaps inBloomFilterfound in a post-review sweep (Closes #107), siblings of the blocked union fix (#106).unionrebuilt its result fromnew BloomFilter({ m, k, seed }), whose constructor re-derives#nfromm/k. It never restored the operand's stored#n, so the union reported a differentbitsPerKey/rateanda.equals(a.union(empty))was false. Membership was never affected (m/k/seed exact) - no false negatives.createset#n = nwithoutassertUint32, unlike blocked'screate, so a largen(e.g.6e9) truncated silently into the uint32 frame field.How
#withN(params, n)that constructs and assigns#n; routecreate,fromBytes, andunionthrough it so the carry-#ninvariant lives in one place.assertUint32(n, "n")increatewhere the unboundednenters.unionnow asserts it preserves the operandbitsPerKeyandequalsthe receiver;createrejectsn > 2^32-1and still accepts2^32-1.Patch changeset included; folds into the pending 0.6.0 release.
Verification
pnpm --filter distillate test: 166 passed#withNis private)🤖 Generated with Claude Code