Pre-1.0 correctness and API hardening - #104
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-1.0 correctness and API hardening from the consolidated review. All on the stable v3 format; the only behavioral changes are validation and the blocked FPR mapping.
Changes
BlockedBloomFilter.createsizes bits-per-key by solving the split-block false-positive rate in closed form instead of interpolating a 3-point anchor table. It now hits the target rate across the full epsilon range (eps=0.1 was silently ~18% before); targets below the solvable floor throwParamError. Docs note the blocked-vs-classic crossover below ~1e-5.kuint16,m/capacityuint32) via a newassertUint16, so out-of-range values throwParamErrorinstead of silently truncating.toByteswrites into a single allocated frame through a newwriteFrameprimitive; the separate body buffer and copy are gone. Output is byte-identical (golden fixtures unchanged).numBlocks/seedaccessors onBlockedBloomFilterandseedonBinaryFuse8/BinaryFuse16for compatibility prechecks.Hash128fields renamedh1lo/h1hi/h2lo/h2hi->w0/w1/w2/w3to match the x86_128 four-word layout.Verification
size:checkclean.docs/api+ API report regenerated; minor changeset added for the 0.6.0 batch.Closes #99
Closes #100
Closes #101
Closes #102
Closes #103