Skip to content

fix: migrate to nostr-sdk 0.45 - #502

Merged
akiomik merged 3 commits into
mainfrom
agent/fix-nostr-sdk-0.45.1
Aug 11, 2026
Merged

fix: migrate to nostr-sdk 0.45#502
akiomik merged 3 commits into
mainfrom
agent/fix-nostr-sdk-0.45.1

Conversation

@akiomik

@akiomik akiomik commented Aug 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • migrate nostui to the nostr-sdk 0.45 API included by Dependabot PR build(deps): bump nostr-sdk from 0.44.1 to 0.45.1 #501
  • preserve read-only npub mode by keeping the public key separate from optional signing keys
  • replace removed signer, tag, subscription, event-builder, and root re-export APIs

Root cause

nostr-sdk 0.45 removes the client signer abstraction, standardized tag APIs, several event-builder helpers, and root-level type re-exports used by nostui.

Validation

  • cargo fmt --all --check
  • cargo test --all-features
  • cargo llvm-cov --all-features --workspace --lcov --output-path /private/tmp/nostui-lcov.info
  • cargo clippy --all-targets --all-features -- -D warnings
  • RUSTDOCFLAGS='-D warnings' cargo doc --no-deps --document-private-items --all-features --workspace --examples
  • typos

Supersedes #501.

dependabot Bot and others added 2 commits August 10, 2026 16:03
Bumps [nostr-sdk](https://github.com/nostrdevkit/nostr) from 0.44.1 to 0.45.1.
- [Commits](https://github.com/nostrdevkit/nostr/commits)

---
updated-dependencies:
- dependency-name: nostr-sdk
  dependency-version: 0.45.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.91%. Comparing base (e331bf5) to head (e6b4eff).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/infrastructure/subscription/nostr.rs 62.85% 39 Missing ⚠️
src/runtime.rs 72.41% 8 Missing ⚠️
src/main.rs 0.00% 4 Missing ⚠️
src/domain/nostr/nip10.rs 97.29% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
+ Coverage   88.82%   88.91%   +0.09%     
==========================================
  Files          42       41       -1     
  Lines        6909     6921      +12     
==========================================
+ Hits         6137     6154      +17     
+ Misses        772      767       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akiomik
akiomik marked this pull request as ready for review August 11, 2026 13:20
@akiomik
akiomik merged commit cafafb3 into main Aug 11, 2026
7 of 8 checks passed
@akiomik
akiomik deleted the agent/fix-nostr-sdk-0.45.1 branch August 11, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant