Repository navigation
React Native: paused prop that holds the face and stops every timer - #17
Merged
Merged
Conversation
…s every timer and loop
…nds and wakes with a fresh burst, and ripple rings keep their stagger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
pausedprop to the React NativeAgentFace.While paused, the face stops its ticker, springs and loops, so it costs almost no CPU. It keeps its expression, ornament, glyph and size, and nothing remounts. Loops and confetti finish their current cycle and then rest, so confetti lands instead of freezing mid-air. Waking starts them again with their normal delays, and the two ripple rings keep their stagger.
Why: an app that shows several live faces kept them animating while they were off screen or the app was in the background. With
pausedthe app can rest faces it is not showing.Tests: 9 new tests cover holding the frame, no remount, the ticker stopping, confetti landing, ripple stagger and the spinner finishing its turn. The full suite, typecheck, lint and build pass.
Minor release (changeset included).