Skip to content

Add defensive zone aliases for EQEmu long_names#75

Merged
ajbtech merged 1 commit into
mainfrom
claude/zone-aliases-eqemu
May 31, 2026
Merged

Add defensive zone aliases for EQEmu long_names#75
ajbtech merged 1 commit into
mainfrom
claude/zone-aliases-eqemu

Conversation

@ajbtech

@ajbtech ajbtech commented May 31, 2026

Copy link
Copy Markdown
Owner

Maps EQEmu's modern zone long_name spellings onto the project's existing canonical map nodes so a log that emits the EQEmu spelling isn't silently dropped as an unknown zone. An alias only ever rescues a zone that would otherwise be dropped — it can't break a name that already resolves.

Sourced from the EQEmu zone table in common/eq_constants.h, diffed against the strings the parser currently accepts (nodes + existing aliases).

Added (34 aliases)

  • The X prefixed forms — Greater/Lesser Faydark, Lavastorm Mountains, Rathe Mountains, Innothule Swamp, Misty Thicket, Steamfont Mountains, Ocean of Tears, Qeynos Hills, Surefall Glade, Estate of Unrest, Dreadlands, Skyfire Mountains, Iceclad Ocean, Great Divide, Planes of Sky/Fear/Hate/Air, the three Karana plains, Qeynos Aqueduct System, Ruins of Old Guk, Permafrost Caverns, Temple of Solusek Ro, Stonebrunt Mountains, City of Thurgadin, Crystal Caverns.
  • Neriak hyphenated districtsNeriak - Foreign Quarter, Neriak - Commons, Neriak - Third Gate (plus the Neriak - 3rd Gate variant, since EQEmu and the P99 wiki disagree on Third/3rd).
  • The City of Guk → Upper Guk.

Notes

  • Most The X forms are defensive — P99 (Trilogy-era) clients most likely omit the leading "The", so these may never actually fire, but they're zero-risk and consistent with the defensive aliases already in the file.
  • Neriak is the one worth a real check: the canonical nodes use the unhyphenated spelling, so if P99 emits the hyphenated form these aliases fix a genuine silent drop. Worth confirming against a real P99 Neriak log line.

Tests

  • New test_defensive_eqemu_aliases_resolve_to_existing_nodes_with_centers asserts every alias resolves to an existing node and has a map center.
  • The alias block is now alphabetically sorted.

https://claude.ai/code/session_01K8NhYEWHmW8kZgPjqGPgcX


Generated by Claude Code

Map EQEmu's modern zone long_names onto existing canonical nodes so a log that
emits the EQEmu spelling isn't dropped as an unknown zone:
- 'The X' prefixed forms (Greater/Lesser Faydark, the Karana plains, planes, etc.)
- Neriak's hyphenated districts ('Neriak - Foreign Quarter/Commons/Third Gate',
  plus the '3rd Gate' variant)
- 'The City of Guk' for Upper Guk
Sourced from the EQEmu zone table in common/eq_constants.h; covered by a new
test asserting each alias resolves to an existing node with a map center.
@ajbtech ajbtech merged commit e035c8a into main May 31, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants