Add defensive zone aliases for EQEmu long_names#75
Merged
Conversation
Map EQEmu's modern zone long_names onto existing canonical nodes so a log that
emits the EQEmu spelling isn't dropped as an unknown zone:
- 'The X' prefixed forms (Greater/Lesser Faydark, the Karana plains, planes, etc.)
- Neriak's hyphenated districts ('Neriak - Foreign Quarter/Commons/Third Gate',
plus the '3rd Gate' variant)
- 'The City of Guk' for Upper Guk
Sourced from the EQEmu zone table in common/eq_constants.h; covered by a new
test asserting each alias resolves to an existing node with a map center.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maps EQEmu's modern zone
long_namespellings onto the project's existing canonical map nodes so a log that emits the EQEmu spelling isn't silently dropped as an unknown zone. An alias only ever rescues a zone that would otherwise be dropped — it can't break a name that already resolves.Sourced from the EQEmu zone table in
common/eq_constants.h, diffed against the strings the parser currently accepts (nodes + existing aliases).Added (34 aliases)
The Xprefixed forms — Greater/Lesser Faydark, Lavastorm Mountains, Rathe Mountains, Innothule Swamp, Misty Thicket, Steamfont Mountains, Ocean of Tears, Qeynos Hills, Surefall Glade, Estate of Unrest, Dreadlands, Skyfire Mountains, Iceclad Ocean, Great Divide, Planes of Sky/Fear/Hate/Air, the three Karana plains, Qeynos Aqueduct System, Ruins of Old Guk, Permafrost Caverns, Temple of Solusek Ro, Stonebrunt Mountains, City of Thurgadin, Crystal Caverns.Neriak - Foreign Quarter,Neriak - Commons,Neriak - Third Gate(plus theNeriak - 3rd Gatevariant, since EQEmu and the P99 wiki disagree on Third/3rd).The City of Guk→ Upper Guk.Notes
The Xforms are defensive — P99 (Trilogy-era) clients most likely omit the leading "The", so these may never actually fire, but they're zero-risk and consistent with the defensive aliases already in the file.Tests
test_defensive_eqemu_aliases_resolve_to_existing_nodes_with_centersasserts every alias resolves to an existing node and has a map center.https://claude.ai/code/session_01K8NhYEWHmW8kZgPjqGPgcX
Generated by Claude Code