refactor: remove dead code, share resource-path logic, cache zone-graph lookups#74
Merged
Merged
Conversation
…ph lookups - Delete unused money_sorter.get_coin_value and log_parser.open_file(s)_and_get_lines - Extract sys._MEIPASS bundle convention into resource_paths.bundled_root, used by eq_display, zone_graph, and ui.asset_paths - Cache zone_graph.get_adjacent_zone_pairs / get_zone_centers (called per-zone in hot loops) with lru_cache - Trim EQList to its production surface (raw + count-alpha ranking) - Unify the in-memory and streaming parse paths via a shared _ingest_lines, and build ParseSummary as a generic projection of ParserState fields so adding a tracked metric no longer means editing a hand-written copy
…-view cleanup - Add SummarySections.character_name so ResultsView reads the name directly instead of stripping the 'Character: ' prefix back off the display string - Extract a table-driven _RunningTotals accumulator from VideoGenerator.frames(), removing the per-event if/elif chain and the 7-arg _stats_lines signature - Move the video-length dialog into ui/views/duration_dialog.py and collapse the five identical bronze-button setups in ResultsView into one helper
- Extract map_path._emits_event shared by build_map_events and cumulative_event_counts so the line/dot/skip rule has one definition - Reuse summary_formatter.format_number in ProgressView instead of a local copy - Hoist 'import math' to module scope in SegmentedProgressBar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
used by eq_display, zone_graph, and ui.asset_paths
in hot loops) with lru_cache
build ParseSummary as a generic projection of ParserState fields so adding a
tracked metric no longer means editing a hand-written copy