Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors profile update and avatar upload functionality to improve user experience and migrate avatar storage from local disk to Amazon S3. It introduces smarter normalization of social profile URLs, expands image format support, and enhances error handling and logging for avatar uploads and deletions.
Profile update improvements:
normalize_urlhelper to intelligently convert user-entered social profile and website fields into proper URLs, accepting both usernames and full URLs for GitHub, Twitter, LinkedIn, and website fields.ProfileUpdateRequestschema fields forwebsite,github,twitter, andlinkedinfromHttpUrltostrto allow flexible input formats, such as usernames or partial URLs.Avatar upload and storage enhancements:
upload_avataranddelete_avatarmethods ins3_service, and updated the avatar upload API to use these methods. This supports more image formats (webpadded) and generates unique S3 URLs for avatars. [1] [2]S3 service improvements:
jpg,jpeg,png,gif,webp).