Chore/implement uv based - #4
Merged
Merged
Conversation
- scripts/bootstrap.sh now uses `uv python install` + `uv sync --all-packages --all-groups`; remove pyenv/pip fallback and reference to nonexistent requirements-dev.txt - Delete per-app requirements*.txt files (app_sample, app_admin, app_nippon_rfq_matching); pyproject.toml is now the single source of truth - Rewrite apps/app_nippon_rfq_matching/Dockerfile to use the workspace-sync pattern from app_docling_api: - build context is the repo root - use `uv sync --no-dev --package app-nippon-rfq-matching` - replace `uv pip install -r requirements.txt` - remove INSTALL_MACOS_REQUIREMENTS arg since macOS deps are gated by sys_platform markers in pyproject.toml - Update apps/app_nippon_rfq_matching/docker-compose.yml: - build context set to `../..` - dockerfile set to `apps/app_nippon_rfq_matching/Dockerfile` - Update apps/app_nippon_rfq_matching/README.md install steps to use scripts/bootstrap.sh
- Drop the `.venv/bin/<tool>` lookup; invoke `uv run --quiet --all-packages --all-groups <tool>` instead. uv auto-syncs the venv against the lockfile before running, so the hooks no longer fail with "command not found" when a narrow `uv sync` has pruned the dev group or workspace deps. - Add an early exit with a clear message if `uv` itself is missing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the workspace fully onto
uvand removes the last pip/requirements.txt holdouts.scripts/bootstrap.shisuv python install+uv sync --all-packages --all-groups(no morepyenv/pip path, no more missing
requirements-dev.txt). Git hooks (.githooks/pre-commit,.githooks/pre-push) calluv run --all-packages --all-groups <tool>so they self-heal if a narrowuv syncever prunes the dev group.requirements.txtfiles deleted. Removedapps/app_sample/requirements.txt,apps/app_admin/requirements.txt,apps/app_nippon_rfq_matching/requirements.txt, andapps/app_nippon_rfq_matching/requirements-macos.txt. Each app'spyproject.tomlis now the single source of truth; macOS-only deps stay gated bysys_platformmarkers.apps/app_docling_api/Dockerfilealready uses): buildcontext is the repo root,
uv sync --no-dev --package app-nippon-rfq-matchingreplacesuv pip install -r requirements.txt, andINSTALL_MACOS_REQUIREMENTSis gone.docker-compose.ymlupdated accordingly (context: ../.., explicitdockerfile:path).Why now
The repo had been half-migrated: root
pyproject.toml+uv.lock+ CI workflow already useduv, butbootstrap.shstillreferenced a nonexistent
requirements-dev.txt, and several apps carried duplicaterequirements.txtfiles that drifted from theirpyproject.toml. This branch closes that gap.