Skip to content

forbid to call get_record and record with named parameters #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicola-spanti-neosoft-airbus-ds wants to merge 1 commit into
base: main
Choose a base branch
from
Open

forbid to call get_record and record with named parameters #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions geocube/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,14 +196,14 @@ def create_records(self, aoi_ids: List[str], names: List[str],
"""
return self._create_records(aoi_ids, names, tags, dates)

def get_record(self, _id: str) -> entities.Record:
def get_record(self, an_id: str, /) -> entities.Record:
""" Deprecated: use record() instead """
return self.record(_id)
return self.record(an_id)

def record(self, _id: str) -> entities.Record:
def record(self, an_id: str, /) -> entities.Record:
""" Get a record by id """
r = self.get_records([_id])
assert len(r) > 0, utils.GeocubeError("get_record", grpc.StatusCode.NOT_FOUND.name, "record with id " + _id)
r = self.get_records([an_id])
assert len(r) > 0, utils.GeocubeError("get_record", grpc.StatusCode.NOT_FOUND.name, "record with id " + an_id)
return r[0]

def get_records(self, ids: List[str]) -> List[entities.Record]:
Expand Down Expand Up @@ -1031,4 +1031,4 @@ def _consolidate(self,
return self.get_job(self.stub.Consolidate(req).job_id)

class Consolidater(Client):
""" Deprecated: use Client instead """
""" Deprecated: use Client instead """