Skip to content

mysql_watcher: created a new basic mysql service watcher#26

Open
qasimkhan wants to merge 5 commits into
airbnb:masterfrom
dubizzle:mysql_watcher
Open

mysql_watcher: created a new basic mysql service watcher#26
qasimkhan wants to merge 5 commits into
airbnb:masterfrom
dubizzle:mysql_watcher

Conversation

@qasimkhan

Copy link
Copy Markdown

This watcher can be used for load balancing

@igor47

igor47 commented Feb 6, 2014

Copy link
Copy Markdown
Collaborator

some comments:

  • i'm not a fan of shelling out when the task can easily be accomplished by built-in modules. it introduces an unenforceable dependency that's left to the system operator, and is pretty expensive. plus, the way you're shelling out here would reveal some db credentials on the command line
  • there are no timeouts enforced here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants