test(ci): stabilize platform-sensitive workflow tests - #773
Conversation
Codex ReviewVerdict: mergeable No actionable findings. Summary: The PR only updates the ACP session creator test to use platform-native path resolution. No concrete merge-blocking defect was introduced. |
Codex ReviewVerdict: mergeable No actionable findings. Summary: The PR only normalizes expected paths in three ACP tests to match production behavior. No concrete blocking defects found. |
9f06863 to
9eb32e9
Compare
Codex ReviewVerdict: mergeable No actionable findings. Summary: The pull request only updates ACP test expectations to use platform-normalized paths, matching the existing implementation. No concrete merge-blocking defects found. |
Codex ReviewVerdict: mergeable No actionable findings. Summary: No concrete merge-blocking defects found in the reviewed changes. |
4e1b81a to
b6e69c3
Compare
Codex ReviewVerdict: mergeable No actionable findings. Summary: No concrete merge-blocking defects found in the pull request changes. |
Problem
The Windows full-test lane on main fails because newly extracted ACP workflow tests expect Unix cwd literals, while production intentionally normalizes cwd values with
node:path.resolve()and returns drive-qualified paths on Windows.Initial failed run: https://github.com/aipoch/open-science/actions/runs/30988121436/job/92247548055
A branch-level Windows full-suite run exposed the same root cause in the provider session resumer and session replacement workflow tests, so this PR covers all three affected assertions.
After rebasing onto the latest main, the Linux unit lane also hit the same 30-second timeout twice in a POSIX-only notebook integration test that intentionally performs repeated real PATH and Conda interpreter discovery.
Proposed change
resolve()semantics in the creator, resumer, and replacement workflow assertions, matching production and the existing ACP runtime test convention.Scope and non-goals
Test-only changes. No production logic, dependencies, architecture, data model, data relationship, or user interaction changes.
Acceptance criteria and validation
All local checks below ran after the last material edit:
npm run typecheck:node-> passednpm run lint-> passed with 0 errors and 17 pre-existing warningsNo production interface or logic changed. The manually dispatched Windows full suite covers the reported platform risk, while PR Gate validates the increased POSIX integration-test budget under the original CI load.
Review focus
node:path.resolve()semantics.