Skip to content

test(ci): stabilize platform-sensitive workflow tests - #773

Merged
ewen-poch merged 3 commits into
mainfrom
fix/acp-session-cwd-portability
Aug 5, 2026
Merged

test(ci): stabilize platform-sensitive workflow tests#773
ewen-poch merged 3 commits into
mainfrom
fix/acp-session-cwd-portability

Conversation

@ewen-poch

@ewen-poch ewen-poch commented Aug 5, 2026

Copy link
Copy Markdown
Member

Problem

The Windows full-test lane on main fails because newly extracted ACP workflow tests expect Unix cwd literals, while production intentionally normalizes cwd values with node:path.resolve() and returns drive-qualified paths on Windows.

Initial failed run: https://github.com/aipoch/open-science/actions/runs/30988121436/job/92247548055

A branch-level Windows full-suite run exposed the same root cause in the provider session resumer and session replacement workflow tests, so this PR covers all three affected assertions.

After rebasing onto the latest main, the Linux unit lane also hit the same 30-second timeout twice in a POSIX-only notebook integration test that intentionally performs repeated real PATH and Conda interpreter discovery.

Proposed change

  • Use the same standard-library resolve() semantics in the creator, resumer, and replacement workflow assertions, matching production and the existing ACP runtime test convention.
  • Give the existing real-interpreter discovery test a 60-second budget, matching other slow notebook integration tests.

Scope and non-goals

Test-only changes. No production logic, dependencies, architecture, data model, data relationship, or user interaction changes.

Acceptance criteria and validation

All local checks below ran after the last material edit:

  • ACP creator/resumer/replacement portable cwd behavior -> 3 files and 21 tests passed
  • complete notebook runtime test file -> 1 file and 181 tests passed in 19.33 seconds
  • npm run typecheck:node -> passed
  • npm run lint -> passed with 0 errors and 17 pre-existing warnings
  • complete real-Windows suite -> https://github.com/aipoch/open-science/actions/runs/30997310575 -> both 1/2 and 2/2 test shards passed

No production interface or logic changed. The manually dispatched Windows full suite covers the reported platform risk, while PR Gate validates the increased POSIX integration-test budget under the original CI load.

Review focus

  • Confirm the ACP assertions follow production's node:path.resolve() semantics.
  • Confirm 60 seconds is appropriate for the existing real-discovery integration test, whose runtime varies with host PATH and Conda environments.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codex Review

Verdict: mergeable

No actionable findings.

Summary: The PR only updates the ACP session creator test to use platform-native path resolution. No concrete merge-blocking defect was introduced.

@github-actions github-actions Bot added ready-to-merge All completed AI reviewers found this pull request mergeable. and removed ready-to-merge All completed AI reviewers found this pull request mergeable. labels Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codex Review

Verdict: mergeable

No actionable findings.

Summary: The PR only normalizes expected paths in three ACP tests to match production behavior. No concrete blocking defects found.

@github-actions github-actions Bot added the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 5, 2026
@ewen-poch
ewen-poch force-pushed the fix/acp-session-cwd-portability branch from 9f06863 to 9eb32e9 Compare August 5, 2026 10:45
@github-actions github-actions Bot removed the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codex Review

Verdict: mergeable

No actionable findings.

Summary: The pull request only updates ACP test expectations to use platform-normalized paths, matching the existing implementation. No concrete merge-blocking defects found.

@github-actions github-actions Bot added ready-to-merge All completed AI reviewers found this pull request mergeable. and removed ready-to-merge All completed AI reviewers found this pull request mergeable. labels Aug 5, 2026
@ewen-poch ewen-poch changed the title test(acp): make session creator cwd assertion portable test(ci): stabilize platform-sensitive workflow tests Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codex Review

Verdict: mergeable

No actionable findings.

Summary: No concrete merge-blocking defects found in the reviewed changes.

@github-actions github-actions Bot added the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 5, 2026
@ewen-poch
ewen-poch force-pushed the fix/acp-session-cwd-portability branch from 4e1b81a to b6e69c3 Compare August 5, 2026 11:19
@github-actions github-actions Bot removed the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codex Review

Verdict: mergeable

No actionable findings.

Summary: No concrete merge-blocking defects found in the pull request changes.

@github-actions github-actions Bot added the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 5, 2026
@ewen-poch
ewen-poch merged commit 8a8f5ae into main Aug 5, 2026
25 of 26 checks passed
@ewen-poch
ewen-poch deleted the fix/acp-session-cwd-portability branch August 5, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge All completed AI reviewers found this pull request mergeable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant