feat(i18n): migrate renderer strings to i18next + catalog fixes - #514
Open
roxi3906 wants to merge 1 commit into
Open
feat(i18n): migrate renderer strings to i18next + catalog fixes#514roxi3906 wants to merge 1 commit into
roxi3906 wants to merge 1 commit into
Conversation
roxi3906
force-pushed
the
claude/magical-kare-96a630
branch
12 times, most recently
from
August 3, 2026 09:35
ca30962 to
4d5a900
Compare
- Convert all hardcoded UI strings in components and pages to useTranslation() / t() across 6 namespaces: common, components, home, onboarding, settings, workspace - Add missing ReviewerCard reflagged key (components.reviewer.reflagged) - Add 8 missing ProviderList keys in settings.model.list/.endpoint (browserLoginHint, tokenPrefix, modelPrefix, keyPrefix, modelsCount, expiresLabel, endpoint.speaksThe) with en/zh-Hans/zh-Hant translations - Fix curly-apostrophe in en/settings.json browserLoginHint (U+2019→U+0027) Simplifications (ponytail-review follow-up): - home-dialogs.render.test: replace 26-line inline mock with createI18nTestStub() from shared test stub - provider-key-security: remove unnecessary ApiKeySecurityCopyKeys named union; TS infers from as-const branches - resources.test: derive leafPaths from leafValues (-4 lines) All 7392 tests pass (kernel-executor failures are pre-existing/environmental) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
roxi3906
force-pushed
the
claude/magical-kare-96a630
branch
from
August 3, 2026 09:55
4d5a900 to
e6efdb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Résumé
Full i18next migration of all hardcoded UI strings in the renderer across 6 namespaces:
common,components,home,onboarding,settings,workspace.New catalog keys
re-flagged ×{{count}}(was hardcoded in ReviewerCard, missed in original migration)browserLoginHint,tokenPrefix,modelPrefix,keyPrefix,modelsCount(plural-aware),expiresLabelBug fixes
en/settings.jsonbrowserLoginHintreplaced with straight apostrophe (U+0027) —toContainin jsdom was failing silently on the mismatchSimplifications
home-dialogs.render.test.tsx: replaced 26-line inline mock reimplementingtranslateForTestwith a singlecreateI18nTestStub()import from the shared test stubprovider-key-security.ts: removedApiKeySecurityCopyKeysnamed union type (9 lines); TypeScript infers the return type from theas constbranchesresources.test.ts:leafPathsnow derived fromleafValuesinstead of duplicating its traversal logicTests
7392 tests pass. The one failing file (
kernel-executor.test.ts) is a pre-existing environmental issue unrelated to this PR.🤖 Generated with Claude Code