Skip to content

Add missing type annotations for function arguments - #625

Open
loqs wants to merge 1 commit into
aio-libs:masterfrom
loqs:flake8-ANN001
Open

Add missing type annotations for function arguments#625
loqs wants to merge 1 commit into
aio-libs:masterfrom
loqs:flake8-ANN001

Conversation

@loqs

@loqs loqs commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

What do these changes do?

Allows removal of related flake8 override.

Are there changes in behavior for the user?

No.

Related issue number

No related issue.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • tox testenvs have been executed in the following environments:
    • Linux (Ubuntu 18.04, Ubuntu 20.04, Arch): {py39,py310,py311,py312}-{nocov,cov,diffcov}, qa, docs
    • Windows (7, 10): {py36,py37,py38,py39}-{nocov,cov,diffcov}
    • WSL 1.0 (Ubuntu 18.04): {py36,py37,py38,py39}-{nocov,cov,diffcov}, pypy3-{nocov,cov}, qa, docs
    • FreeBSD (12.2, 12.1, 11.4): {py36,pypy3}-{nocov,cov,diffcov}, qa
    • Cygwin: py36-{nocov,cov,diffcov}, qa, docs
  • Documentation reflects the changes
  • Add a news fragment into the NEWS.rst file

Allows removal of related flake8 override.
@greptile-apps

greptile-apps Bot commented Aug 15, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge with no actionable behavioral, collection, or lint defect identified.

The added annotations resolve on every supported Python target, match the relevant callback and fixture contracts, and support removal of the ANN001 exemption without changing runtime behavior.

Reviews (1): Last reviewed commit: "Add missing type annotations for functio..." | Re-trigger Greptile

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.84%. Comparing base (ea98162) to head (5b4b614).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   97.81%   97.84%   +0.03%     
==========================================
  Files          23       23              
  Lines        5715     5716       +1     
  Branches      352      352              
==========================================
+ Hits         5590     5593       +3     
+ Misses         75       73       -2     
  Partials       50       50              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant