Fix the linting job; dropping support for python 3.7#466
Open
ilemus wants to merge 6 commits into
Open
Conversation
Author
|
Although the dockerfile was failing to build because the debian version was too old (using python 3.6), the build is still failing for linting with: |
Author
|
I have to update the odbcinst install in the dockerfile |
Author
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The ci docker base image was outdated. This change upgrades from
python:3.6.8-slim-jessietopython:3.8-slim.Why 3.8?
Because the required install dependency (
pyodbc>=5.0.1) only supports python>=3.8. Reference.Subsequently the
setup.pyhad to be updated to drop support for 3.7.To fix the lint job,
twineneeded to be bumped from4.0.2to latest (6.1.0).ipythonneeded to be bumped down from8.13.2to8.12.3because8.13.2supports from python>=3.9.Minor tweaks to the
README.rstAre there changes in behavior for the user?
Dropping support for python 3.7.
Related issue number
Checklist