Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

cid is optional if uid is used. - #5

Open
eventh wants to merge 4 commits into
aio-libs:masterfrom
eventh:master
Open

cid is optional if uid is used.#5
eventh wants to merge 4 commits into
aio-libs:masterfrom
eventh:master

Conversation

@eventh

@eventh eventh commented Jun 27, 2018

Copy link
Copy Markdown
Contributor

When using the uid parameter, cid is optional, see [1].

[1] https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#cid

Signed-off-by: Even Thomassen even.thomassen@noriginmedia.com

Even Thomassen added 2 commits June 27, 2018 23:50
Signed-off-by: Even Thomassen <even.thomassen@noriginmedia.com>
@eventh

eventh commented Jun 28, 2018

Copy link
Copy Markdown
Contributor Author

Tests fails because of python3.4 no longer supported.
Please merge #6 before this can be merged.

@eventh

eventh commented Oct 20, 2018

Copy link
Copy Markdown
Contributor Author

I closed #6 by accident when I was updated it, but #7 is now ready to be merged, to fix the failing tests.

Please merge #7 and this one!

@eventh
eventh requested review from asvetlov and froosty February 15, 2020 12:58
@CLAassistant

This comment has been minimized.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants