Add Python 3.11 - #618
Conversation
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
==========================================
+ Coverage 99.63% 99.66% +0.02%
==========================================
Files 36 36
Lines 3560 3560
==========================================
+ Hits 3547 3548 +1
+ Misses 13 12 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Hello! Changed Enum.format() (the default for format(), str.format() and f-strings) of enums with mixed-in types (e.g. int, str) to also include the class name in the output, not just the member’s key. This matches the existing behavior of enum.Enum.str(), returning e.g. 'AnEnum.MEMBER' for an enum AnEnum(str, Enum) instead of just 'MEMBER'. The _build_key in 3.11 returns If you just need to fix the tests, then something like this works: a68366#2 . I'm not sure if just fixing the tests is enough though, since this change in python's behavior makes aiocache unreliable in an environment where 3.11 and lower versions coexist and enums are used for cache keys. |
|
@a68366 Thanks a lot for digging that out. The actual key values are not important, right? Only that they are consistent. So, what if we just do It'll invalidate existing caches when people upgrade to 0.12, but shouldn't cause any further issues after that. |
|
@a68366 If you could double check the changes look sensible, that would be great. |
|
I'm not so familiar with aiocache codebase, but LGTM.
|
No description provided.