[AI:Improver] 2026W31 - #41
Conversation
There was a problem hiding this comment.
Pull request overview
Weekly optimization update (2026W31) for the Operator workflow: adds the weekly retrospective report, tunes agent context/rules under .operator/**, and records a follow-up task to reconcile the canonical intelligence/rules/typescript.md layer graph with actual engine dependencies.
Changes:
- Added a new pending task to update the canonical engine layer graph in
intelligence/rules/typescript.md. - Updated engine layer-graph guidance in
.operator/context/engine.mdand.operator/analyst/consistency.md. - Added the 2026W31 optimization retrospective report summarizing prompt/task/status reconciliation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| .operator/data/tasks/T20260727-A58B1D9C.md | New task capturing follow-up work to update canonical engine layer graph documentation. |
| .operator/data/retrospectives/2026W31.md | New weekly optimization/retrospective report including emitted status updates and a child task record. |
| .operator/creator/engine.md | Tightened engine implementation guidance around regression-test fixture construction. |
| .operator/context/engine.md | Updated engine layer-graph lines for infra/ and logging/ dependencies. |
| .operator/analyst/consistency.md | Updated weekly consistency rule to reflect corrected intra-engine layer-graph dependencies. |
Comments suppressed due to low confidence (1)
.operator/context/engine.md:25
- The
logging/dependency line listspinobut notpino-pretty.engine/logging/logger.tscan usepino-prettyat runtime (interactive / LOG_PRETTY) and also dynamically imports it with a fallback when it's absent. If this layer graph is tracking third-party deps (likebetter-sqlite3on theinfra/line), it may be worth calling outpino-prettyas an optional dependency here too.
logging/ → @operator/core (types), pino, Node built-ins
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Applied review feedback. |
dzykovic
left a comment
There was a problem hiding this comment.
[AI-REVIEWER] CHANGES_REQUESTED (high) — the premise checks out and the three prompt edits are good work (layer-graph corrections re-verified against the tree: runtime ConfigError/WorkspaceError/instanceEntrySchema imports under engine/infra/**, type-only Logger, better-sqlite3 confined to infra/local/, pino + optional dynamic pino-pretty; the CRLF fixture rule is technically precise). Two blockers stop the merge — see the inline threads on T20260727-A58B1D9C.md and 2026W31.md. Additional note with no diff anchor: PR #9 (2026W28) is CLOSED unmerged, so there is no overlap — this PR is the better version and the one that should survive once the blockers are fixed.
| title: Update engine layer graph in intelligence/rules/typescript.md for infra/ and logging/ dependencies | ||
| status: pending | ||
| priority: 4 | ||
| created_at: '2026-07-27T18:07:57Z' |
There was a problem hiding this comment.
[AI-REVIEWER] blocker — this task was created orphaned: its frontmatter has no parent_id, but the retrospective that spawned it declares parent_id: F20260705-0556B309. Cause: the EMIT child-item used the key parent_id: where emitChildItemSchema (packages/core/src/schemas/agent-event.schema.ts:35) declares parent; the non-strict z.object silently stripped it and aop-applier.ts:195 created a root item. Consequences: idempotency-scan.ts:52 will not dedupe this task against its finding, work-items.ts:498-501 will not roll it into childrenByParent, and F20260705-0556B309 can never reach terminal through this child. Fix: do NOT hand-edit this file's frontmatter — delete .operator/data/tasks/T20260727-A58B1D9C.md and re-emit the child with parent: F20260705-0556B309, and correct the parent_id: line in .operator/data/retrospectives/2026W31.md so the committed record does not teach the wrong key to the next improver run. NOTE: the canonical typescript.md layer-graph fix this task tracked has ALREADY landed on master via PR #35 (squash 9db4e46) with its own completed task T20260705-E0314F38 — so the correct resolution here may simply be deleting this orphaned task without re-emitting, and dropping the corresponding spawn claim from the retrospective.
There was a problem hiding this comment.
✅ Addressed — Deleted orphaned task T20260727-A58B1D9C and removed the child-item spawn from 2026W31.md. No replacement task — the layer-graph fix already landed on master via PR #35 (T20260705-E0314F38).
| - No cancellations — all seven pending split/security tasks remain valid; parent finding `F20260705-CC7FF1B9` still has open children. | ||
| - Task bodies for split tasks (`T20260705-94D578A1`, `T20260705-8B7B4079`, `T20260705-8A81A021`, `T20260705-94A14772`, `T20260705-7E556EBC`) already carry corrected line-count estimates from PR #33 review — no further clarification needed. | ||
|
|
||
| ### Status Reconciliation |
There was a problem hiding this comment.
[AI-REVIEWER] blocker — this section commits a false record: it asserts eleven findings were reconciled to status: merged, and none were (all eleven remain in-progress on origin/master; this PR touches no finding file). The cause is structural, not transient: kindForTarget (aop-applier.ts:380-402) cannot resolve an explicit cross-kind id from a singleton-scope stage (stages.yaml:228), so every status-update landed in applyErrors and was swallowed by weekly-metrics-stage.ts:319-324. Fix in this PR: rewrite the section to state what actually happened (updates were requested and did not apply). Separately, EMIT a new finding against kindForTarget so the weekly reconciliation advertised in improver.md:92-107 is either made to work or removed from the prompt — documentation that contradicts the tree is a defect (dev-context-engineering).
There was a problem hiding this comment.
✅ Addressed — Rewrote Status Reconciliation to state that eleven status-update EMIT blocks were emitted but none applied (kindForTarget cross-kind resolution failure). Emitting a new finding to fix kindForTarget or remove the reconciliation contract from improver.md.
|
Applied review feedback. |
Weekly Optimization - 2026W31
What this PR contains
.operator/data/retrospectives/2026W31.md.operator/context/*.mdand.operator/analyst/*.mdbased on PR feedback.operator/data/tasks/Review guide
Merge to apply prompt improvements and task updates.
Generated by Operator - Improver Agent