Skip to content

Corrected the claim that sbx is never on PATH on Windows and restated the rule as never relying on it, across the rules file, Architecture and three skills - #31

Merged
dzykovic merged 1 commit into
mainfrom
bugfix/path-assumption-docs
Aug 10, 2026
Merged

Corrected the claim that sbx is never on PATH on Windows and restated the rule as never relying on it, across the rules file, Architecture and three skills#31
dzykovic merged 1 commit into
mainfrom
bugfix/path-assumption-docs

Conversation

@dzykovic

Copy link
Copy Markdown
Contributor

Risk & Size

Risk: Low
Size: Small

Documentation and skill text only — no source file changes.

What & Why

CLAUDE.md asserted "sbx is not on PATH (Windows)", and four other places repeated it.
On a v0.31.3 install this is false: HKCU:\Environment carries
%LOCALAPPDATA%\DockerSandboxes\bin\, and sbx.exe resolves through PATH. Whether the
installer adds that entry or the machine's owner did is not determinable after the fact, so
the rule is restated to be true either way and to say the thing that actually matters:
never rely on PATHsbxPath() checks the install location first, on every call, and a
PATH entry cannot rescue the case FR-059 was about anyway (a VS Code window already open when
sbx was installed captured its environment beforehand).

Surfaced while building the FR-059 test harness for #29: the "not installed" simulation was a
no-op until both sources were removed, which is what exposed the stale claim.

No spec: this corrects an inaccurate statement about the environment and adjusts process text.
Per CLAUDE.md, specs record product changes only.

Changes

  • CLAUDE.md — the backend-model bullet now reads "never rely on sbx being on PATH", names
    the resolution order, and notes the stale-environment case.
  • docs/Architecture.md §10 — same correction; states that a PATH entry varies by install
    and is not relied upon.
  • .claude/skills/spec-implement — the trap entry restated, plus "do not reintroduce a memo"
    (the resolution is deliberately uncached since Made a missing prerequisite visible and actionable instead of a silently empty UI, and scoped the host Docker requirement to the custom-image build (FR-059) #29).
  • .claude/skills/dev-onboard — probe the install location rather than PATH; points at
    sbx diagnose, which reports binary, daemon and authentication in one call.
  • .claude/skills/ext-run-local — same, and records what a missing sbx now looks like
    (⚠ Sandbox not available, readiness node, modal on New Sandbox — FR-059).

How to Verify

  1. npm run verify — exits 0 (no source changed; the gate runs anyway per git-commit-push).
  2. grep -rn -i "not on PATH" CLAUDE.md docs/ .claude/ README.md — returns nothing.
  3. Read the five changed passages: none of them now asserts anything about whether a PATH
    entry exists, only that the code must not depend on one.

… the rule as never relying on it, across the rules file, Architecture and three skills
Copilot AI lite review requested due to automatic review settings August 10, 2026 19:58
@dzykovic
dzykovic merged commit c7dece9 into main Aug 10, 2026
2 checks passed
@dzykovic
dzykovic deleted the bugfix/path-assumption-docs branch August 10, 2026 19:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects documentation and process guidance around Windows executable resolution for sbx, replacing the inaccurate claim that it is “not on PATH” with the durable rule the codebase relies on: never depend on PATH because sbxPath() checks the install location first on every call and PATH cannot fix stale-environment VS Code windows.

Changes:

  • Updates CLAUDE.md and docs/Architecture.md to state the correct Windows resolution behavior and why PATH cannot be relied upon.
  • Updates three workflow skills to probe sbx via the install location (not PATH) and to use sbx diagnose as the single readiness probe.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/Architecture.md Restates sbx resolution as “check install location first; PATH may or may not exist and is not relied upon,” with the stale-environment rationale.
CLAUDE.md Replaces “not on PATH” with “never rely on PATH,” aligning the rules with sbxPath()’s per-call resolution behavior.
.claude/skills/spec-implement/SKILL.md Updates the “traps” checklist to the new PATH guidance and reinforces “do not memoize” the resolution.
.claude/skills/ext-run-local/SKILL.md Updates local acceptance prerequisites to probe the install location and use sbx diagnose for readiness checks.
.claude/skills/dev-onboard/SKILL.md Updates onboarding prerequisites to probe the install location rather than PATH and points to sbx diagnose as the consolidated preflight.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants