Skip to content

Track the recommender's unified simulation module in the test mock list#184

Merged
marota merged 1 commit into
ainetus:mainfrom
marota:claude/config-simulation-refactor-182zzz
Jul 5, 2026
Merged

Track the recommender's unified simulation module in the test mock list#184
marota merged 1 commit into
ainetus:mainfrom
marota:claude/config-simulation-refactor-182zzz

Conversation

@marota

@marota marota commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Companion to the expert_op4grid_recommender R4 refactor (v0.2.8), which merged the grid2op / pypowsybl simulation helpers into a single backend-agnostic utils.simulation module and deleted utils.simulation_pypowsybl.

Change

  • expert_backend/tests/conftest.py: update the domain-package mock list to reference expert_op4grid_recommender.utils.simulation instead of the now-deleted utils.simulation_pypowsybl, keeping the mock layer accurate.

Why it's safe

  • No production Co-Study code imports either module (only utils.superposition, utils.make_env_utils, environment*, models, pypowsybl_backend.simulation_env, config, and the main API are used), so the integration is otherwise unchanged.
  • Verified against the real edited recommender: the backend test suite passes (888 tests). The only failures are environmental (missing Graphviz dot binary) plus two golden-trace tests that fail identically on the pre-refactor recommender — i.e. pre-existing recommender/pypowsybl version drift, not caused by this change.
  • The recommender's config contract is preserved (its config module stays plain and mutable), so Co-Study's direct config.* mutations keep working.

🤖 Generated with Claude Code

https://claude.ai/code/session_014npyG1CZHF5LxRL8sa39op

…st mock list

The expert_op4grid_recommender R4 refactor merged the grid2op/pypowsybl
simulation helpers into a single backend-agnostic utils.simulation module and
deleted utils.simulation_pypowsybl. Update the backend test conftest's mock-module
list to reference utils.simulation so the mock layer stays accurate; no
production Co-Study code imports either module, so the integration is otherwise
unchanged (verified against the real recommender).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014npyG1CZHF5LxRL8sa39op
Signed-off-by: Claude <noreply@anthropic.com>
@marota marota force-pushed the claude/config-simulation-refactor-182zzz branch from 2269496 to 6ee7e85 Compare July 4, 2026 20:00
@marota marota merged commit 43e5757 into ainetus:main Jul 5, 2026
11 checks passed
marota pushed a commit to marota/Co-Study4Grid that referenced this pull request Jul 6, 2026
Bring marota/Co-Study4Grid up to date with ainetus/main (PR ainetus#184, the Co-Study
side of the recommender R3/R4 refactor — a conftest mock-list addition). Clean
auto-merge, no conflicts, so the PR into ainetus/main is conflict-free.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XTEMAv3usezBpo2bm2L8qu
Signed-off-by: Antoine Marot <amarot91@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants