Skip to content

add sync API characterization tests - #211

Merged
lxsaah merged 6 commits into
aimdb-dev:mainfrom
harunugurlu:feat/198-non-blocking-api-characterization-tests
Aug 12, 2026
Merged

add sync API characterization tests#211
lxsaah merged 6 commits into
aimdb-dev:mainfrom
harunugurlu:feat/198-non-blocking-api-characterization-tests

Conversation

@harunugurlu

Copy link
Copy Markdown
Collaborator

Summary

  • characterize blocking get() wake-up behavior
  • characterize timeout and successful get_with_timeout() behavior
  • characterize empty and pending try_get() behavior
  • verify ordering and no loss across repeated blocking gets
  • verify blocked consumers return RuntimeShutdown during detach

Verification

  • cargo fmt --all -- --check
  • cargo clippy --package aimdb-sync --all-targets -- -D warnings
  • cargo test -p aimdb-sync
  • make check

Closes #198

@harunugurlu
harunugurlu requested a review from lxsaah as a code owner August 8, 2026 13:52
@harunugurlu

Copy link
Copy Markdown
Collaborator Author

@lxsaah Hi, I'm sorry that it took this long for me to do the work. Been extremely busy with my full-time work. I am waiting for your review, thanks!!

@lxsaah

lxsaah commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

@lxsaah Hi, I'm sorry that it took this long for me to do the work. Been extremely busy with my full-time work. I am waiting for your review, thanks!!

@harunugurlu, don't worry. Thanks a lot for your contribution! I'll have a look as soon as #208 lands. Meanwhile please ensure the the workflows are running successfully. make fmt should fix it!

@lxsaah lxsaah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest holds up, the mpsc handshake is the right answer to the issue's "no sleep-and-hope" constraint. It also passes unmodified against pre-#208, which makes it evidence the rewrite preserved the blocking semantics. Happy to approve once the two items are in.

Comment thread aimdb-sync/tests/characterization_test.rs
Comment thread aimdb-sync/tests/characterization_test.rs Outdated
@lxsaah
lxsaah self-requested a review August 12, 2026 04:12

@lxsaah lxsaah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lxsaah
lxsaah merged commit 625736c into aimdb-dev:main Aug 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aimdb-sync: characterization tests for the blocking API

2 participants