Skip to content

Add more paper references for search plugins. - #313

Open
jendrikseipp wants to merge 3 commits into
aibasel:mainfrom
jendrikseipp:citations
Open

jendrikseipp wants to merge 3 commits into
aibasel:mainfrom
jendrikseipp:citations

Conversation

@jendrikseipp

Copy link
Copy Markdown
Contributor

All references are verified against DBLP.

All references are verified against DBLP.

@grucla grucla left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the references added by this PR against the todo list of issue1200 and added comments where the todo list mentions more or different references.
For most of them I do not know enough to suggest whether to change something or how to change it. I would need to look into the relevant papers for which I have time earliest the week after next.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The todo list of issue1200 also mentions keyder-geffner-ecai2008 for h^add though I do not remember why.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The todo list of issue1200 mentions hoffmann-nebel-jair2001 for the original h^FF and keyder-geffner-ecai2008 for h^FF.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The todo list also mentions keyder-geffner-ecai2008 though I do not remember why.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The todo list has the following comment about lm_exhaust:
We should say something like "Tests for every atom if the relaxed planning task where all achievers of this atom are removed is solvable. If yes, it is a landmark. For the concept of delete relaxation, see: hoffmann-nebel-jair2001 (the FF paper)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The todo list mentions adding the LAMA paper richter-westphal-jair2010 because it describes the algorithm in more detail.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The todo list mentions alkhazraji-et-al-ipc2014 instead of roeger-et-al-socs2020 for limited pruning.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The todo list says that hoffmann-nebel-jair2001 describe EHC but that this is not what is implemented, see summary of
https://issues.fast-downward.org/issue1196

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The todo list mentions the following for lazy weighted A*:

  • lazy aspect:
    • helmert-jair2006
    • richter-helmert-icaps2009
  • weighted: richter-westphal-jair2010

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The todo list also mentions helmert-jair2006.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The todo list also mentions helmert-jair2006.

@SimonDold SimonDold left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only did a partial review

{"Blai Bonet", "Hector Geffner"},
"Planning as Heuristic Search",
"https://doi.org/10.1016/S0004-3702%2801%2900108-4",
"Artificial Intelligence", "129(1-2)", "5-33", "2001"));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The todolist in issue 1200 suggests to add keyder-geffner-ecai2008

Suggested change
"Artificial Intelligence", "129(1-2)", "5-33", "2001"));
"See the paper introducing the additive heuristic:" +
utils::format_journal_reference(
{"Blai Bonet", "Hector Geffner"},
"Planning as Heuristic Search",
"https://doi.org/10.1016/S0004-3702%2801%2900108-4",
"Artificial Intelligence", "129(1-2)", "5-33", "2001") +
"and the paper extending it to non-uniform action costs:" +
utils::format_journal_reference(
{"Emil Keyder", "Hector Geffner"},
"Heuristics for Planning with Action Costs Revisited",
"https://doi.org/10.3233/978-1-58603-891-5-588",
"Proceedings of the 18th European Conference on "
Artificial Intelligence (ECAI 2008)", "178", "588-592", "2008"));

Comment thread src/search/heuristics/ff_heuristic.cc Outdated
"Heuristic Search",
"https://www.jair.org/index.php/jair/article/download/10276/24496",
"Journal of Artificial Intelligence Research", "14", "253-302",
"2001"));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url links to a direct download, the others do not.
It is not the url from DBLP
https://dblp.org/rec/journals/jair/HoffmannN01.html?view=bibtex

The todolist in issue 1200 suggests to add keyder-geffner-ecai2008

Suggested change
"2001"));
"See the paper introducing the FF heuristic:" +
utils::format_journal_reference(
{"Jörg Hoffmann", "Bernhard Nebel"},
"The FF Planning System: Fast Plan Generation Through "
"Heuristic Search",
"https://doi.org/10.1613/jair.855",
"Journal of Artificial Intelligence Research", "14", "253-302",
"2001") +
"and the paper extending it to non-uniform action costs:" +
utils::format_journal_reference(
{"Emil Keyder", "Hector Geffner"},
"Heuristics for Planning with Action Costs Revisited",
"https://doi.org/10.3233/978-1-58603-891-5-588",
"Proceedings of the 18th European Conference on "
Artificial Intelligence (ECAI 2008)", "178", "588-592", "2008"));

Comment thread src/search/heuristics/hm_heuristic.cc Outdated
"https://cdn.aaai.org/AIPS/2000/AIPS00-015.pdf",
"Proceedings of the Fifth International Conference on "
"Artificial Intelligence Planning Systems (AIPS 2000)",
"140-149", "AAAI Press", "2000"));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the todolist from issue1200 suggests to mention that the implementation is very inefficient.

Suggested change
"140-149", "AAAI Press", "2000"));
"140-149", "AAAI Press", "2000") +
"The implementation of the h^m heuristic is preliminary and very inefficient. " +
"Please do not use it for comparison!");

Comment thread src/search/heuristics/hm_heuristic.cc Outdated
utils::format_conference_reference(
{"Patrik Haslum", "Hector Geffner"},
"Admissible Heuristics for Optimal Planning",
"https://cdn.aaai.org/AIPS/2000/AIPS00-015.pdf",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to DBLP (https://dblp.org/rec/conf/aips/HaslumG00.html?view=bibtex) the link is
http://www.aaai.org/Library/AIPS/2000/aips00-015.php

sure it forwards to the same pdf. But the pdf it links to is a pain to read ;_;

Image

We could link to https://www.ida.liu.se/divisions/aiics/publications/AIPS-2000-Admissible-Heuristics-Optimal.pdf instead

Comment thread src/search/heuristics/max_heuristic.cc Outdated
{"Blai Bonet", "Hector Geffner"},
"Planning as Heuristic Search",
"https://doi.org/10.1016/S0004-3702%2801%2900108-4",
"Artificial Intelligence", "129(1-2)", "5-33", "2001"));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paper title is not using this capitalization.

The todolist in issue 1200 suggests to add keyder-geffner-ecai2008

Suggested change
"Artificial Intelligence", "129(1-2)", "5-33", "2001"));
"See the paper introducing the Max heuristic:" +
utils::format_journal_reference(
{"Blai Bonet", "Hector Geffner"},
"Planning as heuristic search",
"https://doi.org/10.1016/S0004-3702%2801%2900108-4",
"Artificial Intelligence", "129(1-2)", "5-33", "2001") +
"and the paper extending it to non-uniform action costs:" +
utils::format_journal_reference(
{"Emil Keyder", "Hector Geffner"},
"Heuristics for Planning with Action Costs Revisited",
"https://doi.org/10.3233/978-1-58603-891-5-588",
"Proceedings of the 18th European Conference on "
Artificial Intelligence (ECAI 2008)", "178", "588-592", "2008"));
);

Add and adjust references following the todo list in issue1200 and the
review comments by Simon and Claudia. Use DOI links instead of direct
PDF downloads.
Replace dead and direct-download links with DOI links, fix the page
numbers of the SoCS 2012 PDB implementation paper, use the original
spelling of author names, and use the title capitalization from DBLP.
@jendrikseipp

Copy link
Copy Markdown
Contributor Author

Thanks, done. I also checked all references against DBLP with Claude: fixed dead/direct-download links (now DOIs), the page numbers of sievers-et-al-socs2012 (49-56), author name spellings, and title capitalization.

Can I merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants