Skip to content

Fix setup safety issues found in review - #2

Merged
seungwonme merged 4 commits into
mainfrom
fix/review-safety-hardening
Jul 13, 2026
Merged

Fix setup safety issues found in review#2
seungwonme merged 4 commits into
mainfrom
fix/review-safety-hardening

Conversation

@seungwonme

@seungwonme seungwonme commented Jul 11, 2026

Copy link
Copy Markdown
Member

What changed

  • keep the beginner Git defaults (Claude Code / noreply@anthropic.com) and explain when they are used
  • preserve complete share links, including the OTEL header value, so students do not need to enter configuration manually
  • disable script copy, download, and one-line execution when no tools are selected
  • reject Windows Store Python aliases, distinguish Docker Desktop from a Docker CLI, and report Codex telemetry write failures
  • create private random runner files and remove those internal temp copies after macOS/Windows one-line execution

Why

This service is for non-developers starting vibe coding. Setup links should work without requiring students to understand Git identity or OTEL credentials, while generated installers should report the applications that are actually installed.

The temporary runner files are internal copies created only by the one-line terminal commands. Downloaded setup files are unchanged and remain on disk.

User impact

  • fresh users can commit with the existing beginner Git defaults
  • instructor-configured OTEL links carry the full configuration
  • empty selections cannot produce runnable output
  • Windows installation status is more accurate
  • one-line runner payloads do not remain in the temp directory after execution

Validation

  • pnpm test
  • pnpm build
  • pnpm test:e2e — 5/5
  • generated macOS script parsed with bash -n
  • generated Windows payload parsed with PowerShell

Actual WinGet/Homebrew package installation was intentionally not run because it would modify the host system.

Repository branch protection is an external GitHub setting and is not part of this code diff.

@seungwonme
seungwonme marked this pull request as ready for review July 13, 2026 02:25
@seungwonme
seungwonme merged commit a2cf5ad into main Jul 13, 2026
4 checks passed
@seungwonme
seungwonme deleted the fix/review-safety-hardening branch July 13, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant